Commit 12c683e1 authored by Laurent Pinchart's avatar Laurent Pinchart Committed by Sam Ravnborg
Browse files

drm: bridge: Pass drm_display_info to drm_bridge_funcs .mode_valid() 



When validating a mode, bridges may need to do so in the context of a
display, as specified by drm_display_info. An example is the meson
dw-hdmi bridge that needs to consider the YUV 4:2:0 output format to
perform clock calculations.

Bridges that need the display info currently retrieve it from the
drm_connector created by the bridge. This gets in the way of moving
connector creation out of bridge drivers. To make this possible, pass
the drm_display_info to drm_bridge_funcs .mode_valid().

Changes to the bridge drivers have been performed with the following
coccinelle semantic patch and have been compile-tested.

@ rule1 @
identifier funcs;
identifier fn;
@@
 struct drm_bridge_funcs funcs = {
 	...,
 	.mode_valid = fn
 };

@ depends on rule1 @
identifier rule1.fn;
identifier bridge;
identifier mode;
@@
 enum drm_mode_status fn(
 	struct drm_bridge *bridge,
+	const struct drm_display_info *info,
 	const struct drm_display_mode *mode
 )
 {
 	...
 }

Signed-off-by: default avatarLaurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
Reviewed-by: default avatarNeil Armstrong <narmstrong@baylibre.com>
Reviewed-by: default avatarBoris Brezillon <boris.brezillon@collabora.com>
Reviewed-by: Guido Günther <agx@sigxcpu.org> # for the nwl-dsi part:
Signed-off-by: default avatarSam Ravnborg <sam@ravnborg.org>
Link: https://patchwork.freedesktop.org/patch/msgid/20200526011505.31884-11-laurent.pinchart+renesas@ideasonboard.com
parent 192a3aa0

drivers/gpu/drm/bridge/analogix/analogix-anx6345.c

+1 −0
Original line number Diff line number Diff line
@@ -585,6 +585,7 @@ static int anx6345_bridge_attach(struct drm_bridge *bridge, 


static enum drm_mode_status

anx6345_bridge_mode_valid(struct drm_bridge *bridge,

			  const struct drm_display_info *info,

			  const struct drm_display_mode *mode)

{

	if (mode->flags & DRM_MODE_FLAG_INTERLACE)

drivers/gpu/drm/bridge/analogix/analogix-anx78xx.c

+1 −0
Original line number Diff line number Diff line
@@ -944,6 +944,7 @@ static int anx78xx_bridge_attach(struct drm_bridge *bridge, 


static enum drm_mode_status

anx78xx_bridge_mode_valid(struct drm_bridge *bridge,

			  const struct drm_display_info *info,

			  const struct drm_display_mode *mode)

{

	if (mode->flags & DRM_MODE_FLAG_INTERLACE)

drivers/gpu/drm/bridge/cdns-dsi.c

+1 −0
Original line number Diff line number Diff line
@@ -663,6 +663,7 @@ static int cdns_dsi_bridge_attach(struct drm_bridge *bridge, 


static enum drm_mode_status

cdns_dsi_bridge_mode_valid(struct drm_bridge *bridge,

			   const struct drm_display_info *info,

			   const struct drm_display_mode *mode)

{

	struct cdns_dsi_input *input = bridge_to_cdns_dsi_input(bridge);

drivers/gpu/drm/bridge/chrontel-ch7033.c

+1 −0
Original line number Diff line number Diff line
@@ -317,6 +317,7 @@ static void ch7033_bridge_detach(struct drm_bridge *bridge) 
}



static enum drm_mode_status ch7033_bridge_mode_valid(struct drm_bridge *bridge,

				     const struct drm_display_info *info,

				     const struct drm_display_mode *mode)

{

	if (mode->clock > 165000)

drivers/gpu/drm/bridge/nwl-dsi.c

+1 −0
Original line number Diff line number Diff line
@@ -818,6 +818,7 @@ static bool nwl_dsi_bridge_mode_fixup(struct drm_bridge *bridge, 


static enum drm_mode_status

nwl_dsi_bridge_mode_valid(struct drm_bridge *bridge,

			  const struct drm_display_info *info,

			  const struct drm_display_mode *mode)

{

	struct nwl_dsi *dsi = bridge_to_dsi(bridge);