Commit 12f7900c authored by Kemeng Shi's avatar Kemeng Shi Committed by Christian Brauner
Browse files

writeback: move wb_wakeup_delayed defination to fs-writeback.c 



The wb_wakeup_delayed is only used in fs-writeback.c. Move it to
fs-writeback.c after defination of wb_wakeup and make it static.

Signed-off-by: default avatarKemeng Shi <shikemeng@huaweicloud.com>
Link: https://lore.kernel.org/r/20240118203339.764093-1-shikemeng@huaweicloud.com


Reviewed-by: default avatarJan Kara <jack@suse.cz>
Signed-off-by: default avatarChristian Brauner <brauner@kernel.org>
parent 73fa7547

fs/fs-writeback.c

+25 −0
Original line number Diff line number Diff line
@@ -141,6 +141,31 @@ static void wb_wakeup(struct bdi_writeback *wb) 
	spin_unlock_irq(&wb->work_lock);

}



/*

 * This function is used when the first inode for this wb is marked dirty. It

 * wakes-up the corresponding bdi thread which should then take care of the

 * periodic background write-out of dirty inodes. Since the write-out would

 * starts only 'dirty_writeback_interval' centisecs from now anyway, we just

 * set up a timer which wakes the bdi thread up later.

 *

 * Note, we wouldn't bother setting up the timer, but this function is on the

 * fast-path (used by '__mark_inode_dirty()'), so we save few context switches

 * by delaying the wake-up.

 *

 * We have to be careful not to postpone flush work if it is scheduled for

 * earlier. Thus we use queue_delayed_work().

 */

static void wb_wakeup_delayed(struct bdi_writeback *wb)

{

	unsigned long timeout;



	timeout = msecs_to_jiffies(dirty_writeback_interval * 10);

	spin_lock_irq(&wb->work_lock);

	if (test_bit(WB_registered, &wb->state))

		queue_delayed_work(bdi_wq, &wb->dwork, timeout);

	spin_unlock_irq(&wb->work_lock);

}



static void finish_writeback_work(struct bdi_writeback *wb,

				  struct wb_writeback_work *work)

{

include/linux/backing-dev.h

+0 −1
Original line number Diff line number Diff line
@@ -38,7 +38,6 @@ struct backing_dev_info *bdi_alloc(int node_id); 


void wb_start_background_writeback(struct bdi_writeback *wb);

void wb_workfn(struct work_struct *work);

void wb_wakeup_delayed(struct bdi_writeback *wb);



void wb_wait_for_completion(struct wb_completion *done);

mm/backing-dev.c

+0 −25
Original line number Diff line number Diff line
@@ -372,31 +372,6 @@ static int __init default_bdi_init(void) 
}

subsys_initcall(default_bdi_init);



/*

 * This function is used when the first inode for this wb is marked dirty. It

 * wakes-up the corresponding bdi thread which should then take care of the

 * periodic background write-out of dirty inodes. Since the write-out would

 * starts only 'dirty_writeback_interval' centisecs from now anyway, we just

 * set up a timer which wakes the bdi thread up later.

 *

 * Note, we wouldn't bother setting up the timer, but this function is on the

 * fast-path (used by '__mark_inode_dirty()'), so we save few context switches

 * by delaying the wake-up.

 *

 * We have to be careful not to postpone flush work if it is scheduled for

 * earlier. Thus we use queue_delayed_work().

 */

void wb_wakeup_delayed(struct bdi_writeback *wb)

{

	unsigned long timeout;



	timeout = msecs_to_jiffies(dirty_writeback_interval * 10);

	spin_lock_irq(&wb->work_lock);

	if (test_bit(WB_registered, &wb->state))

		queue_delayed_work(bdi_wq, &wb->dwork, timeout);

	spin_unlock_irq(&wb->work_lock);

}



static void wb_update_bandwidth_workfn(struct work_struct *work)

{

	struct bdi_writeback *wb = container_of(to_delayed_work(work),