Commit 135a8a4d authored by Stefano Garzarella's avatar Stefano Garzarella Committed by Jakub Kicinski
Browse files

vsock/test: retry send() to avoid occasional failure in sigpipe test 



When the other peer calls shutdown(SHUT_RD), there is a chance that
the send() call could occur before the message carrying the close
information arrives over the transport. In such cases, the send()
might still succeed. To avoid this race, let's retry the send() call
a few times, ensuring the test is more reliable.

Sleep a little before trying again to avoid flooding the other peer
and filling its receive buffer, causing false-negative.

Signed-off-by: default avatarStefano Garzarella <sgarzare@redhat.com>
Link: https://patch.msgid.link/20250514141927.159456-3-sgarzare@redhat.com


Signed-off-by: default avatarJakub Kicinski <kuba@kernel.org>
parent a7262ed4

tools/testing/vsock/vsock_test.c

+30 −8
Original line number Diff line number Diff line
@@ -1058,17 +1058,34 @@ static void sigpipe(int signo) 
	have_sigpipe = 1;

}



#define SEND_SLEEP_USEC (10 * 1000)



static void test_stream_check_sigpipe(int fd)

{

	ssize_t res;



	have_sigpipe = 0;



	/* When the other peer calls shutdown(SHUT_RD), there is a chance that

	 * the send() call could occur before the message carrying the close

	 * information arrives over the transport. In such cases, the send()

	 * might still succeed. To avoid this race, let's retry the send() call

	 * a few times, ensuring the test is more reliable.

	 */

	timeout_begin(TIMEOUT);

	while(1) {

		res = send(fd, "A", 1, 0);

	if (res != -1) {

		fprintf(stderr, "expected send(2) failure, got %zi\n", res);

		exit(EXIT_FAILURE);

		if (res == -1)

			break;



		/* Sleep a little before trying again to avoid flooding the

		 * other peer and filling its receive buffer, causing

		 * false-negative.

		 */

		timeout_usleep(SEND_SLEEP_USEC);

		timeout_check("send");

	}

	timeout_end();



	if (!have_sigpipe) {

		fprintf(stderr, "SIGPIPE expected\n");
@@ -1077,11 +1094,16 @@ static void test_stream_check_sigpipe(int fd) 


	have_sigpipe = 0;



	timeout_begin(TIMEOUT);

	while(1) {

		res = send(fd, "A", 1, MSG_NOSIGNAL);

	if (res != -1) {

		fprintf(stderr, "expected send(2) failure, got %zi\n", res);

		exit(EXIT_FAILURE);

		if (res == -1)

			break;



		timeout_usleep(SEND_SLEEP_USEC);

		timeout_check("send");

	}

	timeout_end();



	if (have_sigpipe) {

		fprintf(stderr, "SIGPIPE not expected\n");