Commit 142ba31d authored by Zijun Hu's avatar Zijun Hu Committed by Greg Kroah-Hartman
Browse files

PM: wakeup: Do not expose 4 device wakeup source APIs 



The following 4 APIs are only used by drivers/base/power/wakeup.c
internally.

- wakeup_source_create()
- wakeup_source_destroy()
- wakeup_source_add()
- wakeup_source_remove()

Do not expose them by making them as static functions.

Signed-off-by: default avatarZijun Hu <quic_zijuhu@quicinc.com>
Link: https://lore.kernel.org/r/20250420-fix_power-v2-1-9b938d2283aa@quicinc.com


Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 93b27a84

drivers/base/power/wakeup.c

+4 −8
Original line number Diff line number Diff line
@@ -77,7 +77,7 @@ static DEFINE_IDA(wakeup_ida); 
 * wakeup_source_create - Create a struct wakeup_source object.

 * @name: Name of the new wakeup source.

 */

struct wakeup_source *wakeup_source_create(const char *name)

static struct wakeup_source *wakeup_source_create(const char *name)

{

	struct wakeup_source *ws;

	const char *ws_name;
@@ -106,7 +106,6 @@ struct wakeup_source *wakeup_source_create(const char *name) 
err_ws:

	return NULL;

}

EXPORT_SYMBOL_GPL(wakeup_source_create);



/*

 * Record wakeup_source statistics being deleted into a dummy wakeup_source.
@@ -149,7 +148,7 @@ static void wakeup_source_free(struct wakeup_source *ws) 
 *

 * Use only for wakeup source objects created with wakeup_source_create().

 */

void wakeup_source_destroy(struct wakeup_source *ws)

static void wakeup_source_destroy(struct wakeup_source *ws)

{

	if (!ws)

		return;
@@ -158,13 +157,12 @@ void wakeup_source_destroy(struct wakeup_source *ws) 
	wakeup_source_record(ws);

	wakeup_source_free(ws);

}

EXPORT_SYMBOL_GPL(wakeup_source_destroy);



/**

 * wakeup_source_add - Add given object to the list of wakeup sources.

 * @ws: Wakeup source object to add to the list.

 */

void wakeup_source_add(struct wakeup_source *ws)

static void wakeup_source_add(struct wakeup_source *ws)

{

	unsigned long flags;
@@ -179,13 +177,12 @@ void wakeup_source_add(struct wakeup_source *ws) 
	list_add_rcu(&ws->entry, &wakeup_sources);

	raw_spin_unlock_irqrestore(&events_lock, flags);

}

EXPORT_SYMBOL_GPL(wakeup_source_add);



/**

 * wakeup_source_remove - Remove given object from the wakeup sources list.

 * @ws: Wakeup source object to remove from the list.

 */

void wakeup_source_remove(struct wakeup_source *ws)

static void wakeup_source_remove(struct wakeup_source *ws)

{

	unsigned long flags;
@@ -204,7 +201,6 @@ void wakeup_source_remove(struct wakeup_source *ws) 
	 */

	ws->timer.function = NULL;

}

EXPORT_SYMBOL_GPL(wakeup_source_remove);



/**

 * wakeup_source_register - Create wakeup source and add it to the list.

include/linux/pm_wakeup.h

+0 −15
Original line number Diff line number Diff line
@@ -95,10 +95,6 @@ static inline void device_set_wakeup_path(struct device *dev) 
}



/* drivers/base/power/wakeup.c */

extern struct wakeup_source *wakeup_source_create(const char *name);

extern void wakeup_source_destroy(struct wakeup_source *ws);

extern void wakeup_source_add(struct wakeup_source *ws);

extern void wakeup_source_remove(struct wakeup_source *ws);

extern struct wakeup_source *wakeup_source_register(struct device *dev,

						    const char *name);

extern void wakeup_source_unregister(struct wakeup_source *ws);
@@ -129,17 +125,6 @@ static inline bool device_can_wakeup(struct device *dev) 
	return dev->power.can_wakeup;

}



static inline struct wakeup_source *wakeup_source_create(const char *name)

{

	return NULL;

}



static inline void wakeup_source_destroy(struct wakeup_source *ws) {}



static inline void wakeup_source_add(struct wakeup_source *ws) {}



static inline void wakeup_source_remove(struct wakeup_source *ws) {}



static inline struct wakeup_source *wakeup_source_register(struct device *dev,

							   const char *name)

{