Commit 143981aa authored by Joe Hattori's avatar Joe Hattori Committed by Wim Van Sebroeck
Browse files

watchdog: rti_wdt: Fix an OF node leak in rti_wdt_probe() 



rti_wdt_probe() does not release the OF node reference obtained by
of_parse_phandle(). Add a of_node_put() call.

This was found by an experimental verification tool that I am
developing. Due to the lack of the actual device, no runtime test was
able to be performed.

Fixes: f20ca595 ("watchdog:rit_wdt: Add support for WDIOF_CARDRESET")
Signed-off-by: default avatarJoe Hattori <joe@pf.is.s.u-tokyo.ac.jp>
Reviewed-by: default avatarGuenter Roeck <linux@roeck-us.net>
Link: https://lore.kernel.org/r/20250105111718.4184192-1-joe@pf.is.s.u-tokyo.ac.jp


Signed-off-by: default avatarGuenter Roeck <linux@roeck-us.net>
Signed-off-by: default avatarWim Van Sebroeck <wim@linux-watchdog.org>
parent 7da5fc34

drivers/watchdog/rti_wdt.c

+1 −0
Original line number Diff line number Diff line
@@ -302,6 +302,7 @@ static int rti_wdt_probe(struct platform_device *pdev) 
	node = of_parse_phandle(pdev->dev.of_node, "memory-region", 0);

	if (node) {

		ret = of_address_to_resource(node, 0, &res);

		of_node_put(node);

		if (ret) {

			dev_err(dev, "No memory address assigned to the region.\n");

			goto err_iomap;