Commit 145e1da3 authored by Raghavendra Rao Ananta's avatar Raghavendra Rao Ananta Committed by Bjorn Andersson
Browse files

remoteproc: sysfs: Use sysfs_emit instead of sprintf 



For security reasons sysfs_emit() is preferred over sprintf().
Hence, convert the remoteproc's sysfs show functions accordingly.

Signed-off-by: default avatarRaghavendra Rao Ananta <rananta@codeaurora.org>
Signed-off-by: default avatarSiddharth Gupta <sidgup@codeaurora.org>
Link: https://lore.kernel.org/r/1614808022-26062-1-git-send-email-sidgup@codeaurora.org


Signed-off-by: default avatarBjorn Andersson <bjorn.andersson@linaro.org>
parent a38fd874

drivers/remoteproc/remoteproc_sysfs.c

+2 −2
Original line number Diff line number Diff line
@@ -15,7 +15,7 @@ static ssize_t recovery_show(struct device *dev, 
{

	struct rproc *rproc = to_rproc(dev);



	return sprintf(buf, "%s", rproc->recovery_disabled ? "disabled\n" : "enabled\n");

	return sysfs_emit(buf, "%s", rproc->recovery_disabled ? "disabled\n" : "enabled\n");

}



/*
@@ -82,7 +82,7 @@ static ssize_t coredump_show(struct device *dev, 
{

	struct rproc *rproc = to_rproc(dev);



	return sprintf(buf, "%s\n", rproc_coredump_str[rproc->dump_conf]);

	return sysfs_emit(buf, "%s\n", rproc_coredump_str[rproc->dump_conf]);

}



/*