Commit 1560cb0e authored by Masahiro Yamada's avatar Masahiro Yamada
Browse files

modpost: remove unneeded .symbol_white_list initializers 



The ->symbol_white_list field is referenced in secref_whitelist(),
only when 'fromsec' is data_sections.

        /* Check for pattern 2 */
        if (match(tosec, init_exit_sections) &&
            match(fromsec, data_sections) &&
            match(fromsym, mismatch->symbol_white_list))
                return 0;

If .fromsec is not data sections, the .symbol_white_list member is
not used by anyone.

Signed-off-by: default avatarMasahiro Yamada <masahiroy@kernel.org>
parent 7452dd26

scripts/mod/modpost.c

+0 −8
Original line number Diff line number Diff line
@@ -930,7 +930,6 @@ static const struct sectioncheck sectioncheck[] = { 
	.fromsec = { TEXT_SECTIONS, NULL },

	.bad_tosec = { ALL_INIT_SECTIONS, NULL },

	.mismatch = TEXT_TO_ANY_INIT,

	.symbol_white_list = { DEFAULT_SYMBOL_WHITE_LIST, NULL },

},

{

	.fromsec = { DATA_SECTIONS, NULL },
@@ -951,7 +950,6 @@ static const struct sectioncheck sectioncheck[] = { 
	.fromsec = { TEXT_SECTIONS, NULL },

	.bad_tosec = { ALL_EXIT_SECTIONS, NULL },

	.mismatch = TEXT_TO_ANY_EXIT,

	.symbol_white_list = { DEFAULT_SYMBOL_WHITE_LIST, NULL },

},

{

	.fromsec = { DATA_SECTIONS, NULL },
@@ -964,41 +962,35 @@ static const struct sectioncheck sectioncheck[] = { 
	.fromsec = { ALL_XXXINIT_SECTIONS, NULL },

	.bad_tosec = { INIT_SECTIONS, NULL },

	.mismatch = XXXINIT_TO_SOME_INIT,

	.symbol_white_list = { DEFAULT_SYMBOL_WHITE_LIST, NULL },

},

/* Do not reference exit code/data from memexit code/data */

{

	.fromsec = { ALL_XXXEXIT_SECTIONS, NULL },

	.bad_tosec = { EXIT_SECTIONS, NULL },

	.mismatch = XXXEXIT_TO_SOME_EXIT,

	.symbol_white_list = { DEFAULT_SYMBOL_WHITE_LIST, NULL },

},

/* Do not use exit code/data from init code */

{

	.fromsec = { ALL_INIT_SECTIONS, NULL },

	.bad_tosec = { ALL_EXIT_SECTIONS, NULL },

	.mismatch = ANY_INIT_TO_ANY_EXIT,

	.symbol_white_list = { DEFAULT_SYMBOL_WHITE_LIST, NULL },

},

/* Do not use init code/data from exit code */

{

	.fromsec = { ALL_EXIT_SECTIONS, NULL },

	.bad_tosec = { ALL_INIT_SECTIONS, NULL },

	.mismatch = ANY_EXIT_TO_ANY_INIT,

	.symbol_white_list = { DEFAULT_SYMBOL_WHITE_LIST, NULL },

},

{

	.fromsec = { ALL_PCI_INIT_SECTIONS, NULL },

	.bad_tosec = { INIT_SECTIONS, NULL },

	.mismatch = ANY_INIT_TO_ANY_EXIT,

	.symbol_white_list = { NULL },

},

/* Do not export init/exit functions or data */

{

	.fromsec = { "___ksymtab*", NULL },

	.bad_tosec = { INIT_SECTIONS, EXIT_SECTIONS, NULL },

	.mismatch = EXPORT_TO_INIT_EXIT,

	.symbol_white_list = { DEFAULT_SYMBOL_WHITE_LIST, NULL },

},

{

	.fromsec = { "__ex_table", NULL },