Commit 16ac1b6a authored by Robin Chen's avatar Robin Chen Committed by Alex Deucher
Browse files

drm/amd/display: Remove unused DMUB replay commands 



[WHY]
Remove unused DMUB Replay set version command and related code.

Reviewed-by: default avatarJack Chang <jack.chang@amd.com>
Signed-off-by: default avatarRobin Chen <robin.chen@amd.com>
Signed-off-by: default avatarMatthew Stewart <matthew.stewart2@amd.com>
Tested-by: default avatarDan Wheeler <daniel.wheeler@amd.com>
Signed-off-by: default avatarAlex Deucher <alexander.deucher@amd.com>
parent 872818e2

drivers/gpu/drm/amd/display/dc/dc_types.h

+0 −1
Original line number Diff line number Diff line
@@ -1101,7 +1101,6 @@ enum replay_FW_Message_type { 
	Replay_Set_Residency_Frameupdate_Timer,

	Replay_Set_Pseudo_VTotal,

	Replay_Disabled_Adaptive_Sync_SDP,

	Replay_Set_Version,

	Replay_Set_General_Cmd,

};

drivers/gpu/drm/amd/display/dc/dce/dmub_replay.c

+0 −13
Original line number Diff line number Diff line
@@ -387,19 +387,6 @@ static void dmub_replay_send_cmd(struct dmub_replay *dmub, 
		cmd.replay_disabled_adaptive_sync_sdp.data.force_disabled =

			cmd_element->disabled_adaptive_sync_sdp_data.force_disabled;

		break;

	case Replay_Set_Version:

		//Header

		cmd.replay_set_version.header.sub_type =

			DMUB_CMD__REPLAY_SET_VERSION;

		cmd.replay_set_version.header.payload_bytes =

			sizeof(struct dmub_rb_cmd_replay_set_version) -

			sizeof(struct dmub_cmd_header);

		//Cmd Body

		cmd.replay_set_version.replay_set_version_data.panel_inst =

			cmd_element->version_data.panel_inst;

		cmd.replay_set_version.replay_set_version_data.version =

			cmd_element->version_data.version;

		break;

	case Replay_Set_General_Cmd:

		//Header

		cmd.replay_set_general_cmd.header.sub_type =

drivers/gpu/drm/amd/display/dmub/inc/dmub_cmd.h

+0 −46
Original line number Diff line number Diff line
@@ -4334,10 +4334,6 @@ enum dmub_cmd_replay_type { 
	 * Set adaptive sync sdp enabled

	 */

	DMUB_CMD__REPLAY_DISABLED_ADAPTIVE_SYNC_SDP = 8,

	/**

	 * Set version

	 */

	DMUB_CMD__REPLAY_SET_VERSION = 9,

	/**

	 * Set Replay General command.

	 */
@@ -4505,40 +4501,6 @@ enum replay_version { 
	REPLAY_VERSION_UNSUPPORTED		= 0xFF,

};



/**

 * Data passed from driver to FW in a DMUB_CMD___SET_REPLAY_VERSION command.

 */

struct dmub_cmd_replay_set_version_data {

	/**

	 * Panel Instance.

	 * Panel instance to identify which psr_state to use

	 * Currently the support is only for 0 or 1

	 */

	uint8_t panel_inst;

	/**

	 * Replay version that FW should implement.

	 */

	enum replay_version version;

	/**

	 * Explicit padding to 4 byte boundary.

	 */

	uint8_t pad[3];

};



/**

 * Definition of a DMUB_CMD__REPLAY_SET_VERSION command.

 */

struct dmub_rb_cmd_replay_set_version {

	/**

	 * Command header.

	 */

	struct dmub_cmd_header header;

	/**

	 * Data passed from driver to FW in a DMUB_CMD__REPLAY_SET_VERSION command.

	 */

	struct dmub_cmd_replay_set_version_data replay_set_version_data;

};



/**

 * Definition of a DMUB_CMD__REPLAY_COPY_SETTINGS command.

 */
@@ -4929,10 +4891,6 @@ union dmub_replay_cmd_set { 
	 * Definition of DMUB_CMD__REPLAY_DISABLED_ADAPTIVE_SYNC_SDP command data.

	 */

	struct dmub_cmd_replay_disabled_adaptive_sync_sdp_data disabled_adaptive_sync_sdp_data;

	/**

	 * Definition of DMUB_CMD__REPLAY_SET_VERSION command data.

	 */

	struct dmub_cmd_replay_set_version_data version_data;

	/**

	 * Definition of DMUB_CMD__REPLAY_SET_GENERAL_CMD command data.

	 */
@@ -7020,10 +6978,6 @@ union dmub_rb_cmd { 
	 * Definition of a DMUB_CMD__IDLE_OPT_SET_DC_POWER_STATE command.

	 */

	struct dmub_rb_cmd_idle_opt_set_dc_power_state idle_opt_set_dc_power_state;

	/**

	 * Definition of a DMUB_CMD__REPLAY_SET_VERSION command.

	 */

	struct dmub_rb_cmd_replay_set_version replay_set_version;

	/*

	 * Definition of a DMUB_CMD__REPLAY_COPY_SETTINGS command.

	 */