Commit 170940f7 authored by Bjorn Andersson's avatar Bjorn Andersson Committed by Greg Kroah-Hartman
Browse files

usb: dwc3: core: Don't touch resets and clocks 



When the core is integrated with glue, it's reasonable to assume that
the glue driver will have to touch the IP before/after the core takes
the hardware out and into reset. As such the glue must own these
resources and be allowed to turn them on/off outside the core's
handling.

Allow the platform or glue layer to indicate if the core logic for
clocks and resets should be skipped to deal with this.

Reviewed-by: default avatarFrank Li <Frank.Li@nxp.com>
Acked-by: default avatarThinh Nguyen <Thinh.Nguyen@synopsys.com>
Tested-by: Neil Armstrong <neil.armstrong@linaro.org> # on SM8650-QRD
Signed-off-by: default avatarBjorn Andersson <bjorn.andersson@oss.qualcomm.com>
Link: https://lore.kernel.org/r/20250414-dwc3-refactor-v7-4-f015b358722d@oss.qualcomm.com


Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 613a2e65

drivers/usb/dwc3/core.c

+11 −9
Original line number Diff line number Diff line
@@ -2211,6 +2211,7 @@ int dwc3_core_probe(const struct dwc3_probe_data *data) 
	if (IS_ERR(dwc->usb_psy))

		return dev_err_probe(dev, PTR_ERR(dwc->usb_psy), "couldn't get usb power supply\n");



	if (!data->ignore_clocks_and_resets) {

		dwc->reset = devm_reset_control_array_get_optional_shared(dev);

		if (IS_ERR(dwc->reset)) {

			ret = PTR_ERR(dwc->reset);
@@ -2220,6 +2221,7 @@ int dwc3_core_probe(const struct dwc3_probe_data *data) 
		ret = dwc3_get_clocks(dwc);

		if (ret)

			goto err_put_psy;

	}



	ret = reset_control_deassert(dwc->reset);

	if (ret)
@@ -2334,7 +2336,7 @@ EXPORT_SYMBOL_GPL(dwc3_core_probe); 


static int dwc3_probe(struct platform_device *pdev)

{

	struct dwc3_probe_data probe_data;

	struct dwc3_probe_data probe_data = {};

	struct resource *res;

	struct dwc3 *dwc;

drivers/usb/dwc3/glue.h

+3 −0
Original line number Diff line number Diff line
@@ -13,10 +13,13 @@ 
 * dwc3_probe_data: Initialization parameters passed to dwc3_core_probe()

 * @dwc: Reference to dwc3 context structure

 * @res: resource for the DWC3 core mmio region

 * @ignore_clocks_and_resets: clocks and resets defined for the device should

 *		be ignored by the DWC3 core, as they are managed by the glue

 */

struct dwc3_probe_data {

	struct dwc3 *dwc;

	struct resource *res;

	bool ignore_clocks_and_resets;

};



int dwc3_core_probe(const struct dwc3_probe_data *data);