Commit 170e086a authored by Jens Axboe's avatar Jens Axboe
Browse files

nvme: fix bogus kzalloc() return check in nvme_init_effects_log() 



nvme_init_effects_log() returns failure when kzalloc() is successful,
which is obviously wrong and causes failures to boot. Correct the
check.

Fixes: d4a95ade ("nvme: Add error path for xa_store in nvme_init_effects")
Signed-off-by: default avatarJens Axboe <axboe@kernel.dk>
parent e494e451

drivers/nvme/host/core.c

+1 −1
Original line number Diff line number Diff line
@@ -3182,7 +3182,7 @@ static int nvme_init_effects_log(struct nvme_ctrl *ctrl, 
	struct nvme_effects_log *effects, *old;



	effects = kzalloc(sizeof(*effects), GFP_KERNEL);

	if (effects)

	if (!effects)

		return -ENOMEM;



	old = xa_store(&ctrl->cels, csi, effects, GFP_KERNEL);