Commit 172bf5ed authored by Jinjie Ruan's avatar Jinjie Ruan Committed by Viresh Kumar
Browse files

cpufreq: mediatek-hw: Fix wrong return value in mtk_cpufreq_get_cpu_power() 



mtk_cpufreq_get_cpu_power() return 0 if the policy is NULL. Then in
em_create_perf_table(), the later zero check for power is not invalid
as power is uninitialized. As Lukasz suggested, it must return -EINVAL when
the 'policy' is not found. So return -EINVAL to fix it.

Cc: stable@vger.kernel.org
Fixes: 4855e26b ("cpufreq: mediatek-hw: Add support for CPUFREQ HW")
Reviewed-by: default avatarLukasz Luba <lukasz.luba@arm.com>
Suggested-by: default avatarLukasz Luba <lukasz.luba@arm.com>
Signed-off-by: default avatarJinjie Ruan <ruanjinjie@huawei.com>
Signed-off-by: default avatarViresh Kumar <viresh.kumar@linaro.org>
parent b51eb087

drivers/cpufreq/mediatek-cpufreq-hw.c

+1 −1
Original line number Diff line number Diff line
@@ -62,7 +62,7 @@ mtk_cpufreq_get_cpu_power(struct device *cpu_dev, unsigned long *uW, 


	policy = cpufreq_cpu_get_raw(cpu_dev->id);

	if (!policy)

		return 0;

		return -EINVAL;



	data = policy->driver_data;