Commit 17a0374b authored by Stanislav Fomichev's avatar Stanislav Fomichev Committed by Jakub Kicinski
Browse files

selftests: ncdevmem: remove sleep on rx 

RX devmem sometimes fails on NIPA:

https://netdev-3.bots.linux.dev/vmksft-fbnic-qemu-dbg/results/294402/7-devmem-py/



Both RSS and flow steering are properly installed, but the wait_port_listen
fails. Try to remove sleep(1) to see if the cause of the failure is
spending too much time during RX setup. I don't see a good reason to
have sleep in the first place. If there needs to be a delay between
installing the rules and receiving the traffic, let's add it to the
callers (devmem.py) instead.

Signed-off-by: default avatarStanislav Fomichev <sdf@fomichev.me>
Reviewed-by: default avatarMina Almasry <almasrymina@google.com>
Link: https://patch.msgid.link/20250912170611.676110-1-sdf@fomichev.me


Signed-off-by: default avatarJakub Kicinski <kuba@kernel.org>
parent ba5c906d

tools/testing/selftests/drivers/net/hw/ncdevmem.c

+0 −2
Original line number Diff line number Diff line
@@ -872,8 +872,6 @@ static int do_server(struct memory_buffer *mem) 
		goto err_reset_rss;

	}



	sleep(1);



	if (bind_rx_queue(ifindex, mem->fd, create_queues(), num_queues, &ys)) {

		pr_err("Failed to bind");

		goto err_reset_flow_steering;