Commit 17d28aa8 authored by Matthew Auld's avatar Matthew Auld Committed by Rodrigo Vivi
Browse files

drm/xe: don't warn for bogus pagefaults 

This appears to be easily user triggerable so warning is perhaps too
much. Rather just make it debug print.

Closes: https://gitlab.freedesktop.org/drm/xe/kernel/-/issues/534


Signed-off-by: default avatarMatthew Auld <matthew.auld@intel.com>
Cc: Matthew Brost <matthew.brost@intel.com>
Reviewed-by: default avatarMatthew Brost <matthew.brost@intel.com>
Signed-off-by: default avatarRodrigo Vivi <rodrigo.vivi@intel.com>
parent 7f6c6e50

drivers/gpu/drm/xe/xe_gt_pagefault.c

+2 −2
Original line number Diff line number Diff line
@@ -265,7 +265,7 @@ static int send_pagefault_reply(struct xe_guc *guc, 


static void print_pagefault(struct xe_device *xe, struct pagefault *pf)

{

	drm_warn(&xe->drm, "\n\tASID: %d\n"

	drm_dbg(&xe->drm, "\n\tASID: %d\n"

		 "\tVFID: %d\n"

		 "\tPDATA: 0x%04x\n"

		 "\tFaulted Address: 0x%08x%08x\n"
@@ -370,7 +370,7 @@ static void pf_queue_work_func(struct work_struct *w) 
	if (unlikely(ret)) {

		print_pagefault(xe, &pf);

		pf.fault_unsuccessful = 1;

		drm_warn(&xe->drm, "Fault response: Unsuccessful %d\n", ret);

		drm_dbg(&xe->drm, "Fault response: Unsuccessful %d\n", ret);

	}



	reply.dw0 = FIELD_PREP(PFR_VALID, 1) |

drivers/gpu/drm/xe/xe_guc_submit.c

+1 −1
Original line number Diff line number Diff line
@@ -1641,7 +1641,7 @@ int xe_guc_exec_queue_memory_cat_error_handler(struct xe_guc *guc, u32 *msg, 
	if (unlikely(!q))

		return -EPROTO;



	drm_warn(&xe->drm, "Engine memory cat error: guc_id=%d", guc_id);

	drm_dbg(&xe->drm, "Engine memory cat error: guc_id=%d", guc_id);

	trace_xe_exec_queue_memory_cat_error(q);



	/* Treat the same as engine reset */