Unverified Commit 1851e783 authored by Samuel Holland's avatar Samuel Holland Committed by Palmer Dabbelt
Browse files

RISC-V: KVM: Allow Smnpm and Ssnpm extensions for guests 



The interface for controlling pointer masking in VS-mode is henvcfg.PMM,
which is part of the Ssnpm extension, even though pointer masking in
HS-mode is provided by the Smnpm extension. As a result, emulating Smnpm
in the guest requires (only) Ssnpm on the host.

The guest configures Smnpm through the SBI Firmware Features extension,
which KVM does not yet implement, so currently the ISA extension has no
visible effect on the guest, and thus it cannot be disabled. Ssnpm is
configured using the senvcfg CSR within the guest, so that extension
cannot be hidden from the guest without intercepting writes to the CSR.

Signed-off-by: default avatarSamuel Holland <samuel.holland@sifive.com>
Reviewed-by: default avatarAnup Patel <anup@brainfault.org>
Link: https://lore.kernel.org/r/20241016202814.4061541-10-samuel.holland@sifive.com


Signed-off-by: default avatarPalmer Dabbelt <palmer@rivosinc.com>
parent 3c2e0aff

arch/riscv/include/uapi/asm/kvm.h

+2 −0
Original line number Diff line number Diff line
@@ -175,6 +175,8 @@ enum KVM_RISCV_ISA_EXT_ID { 
	KVM_RISCV_ISA_EXT_ZCF,

	KVM_RISCV_ISA_EXT_ZCMOP,

	KVM_RISCV_ISA_EXT_ZAWRS,

	KVM_RISCV_ISA_EXT_SMNPM,

	KVM_RISCV_ISA_EXT_SSNPM,

	KVM_RISCV_ISA_EXT_MAX,

};

arch/riscv/kvm/vcpu_onereg.c

+4 −0
Original line number Diff line number Diff line
@@ -34,9 +34,11 @@ static const unsigned long kvm_isa_ext_arr[] = { 
	[KVM_RISCV_ISA_EXT_M] = RISCV_ISA_EXT_m,

	[KVM_RISCV_ISA_EXT_V] = RISCV_ISA_EXT_v,

	/* Multi letter extensions (alphabetically sorted) */

	[KVM_RISCV_ISA_EXT_SMNPM] = RISCV_ISA_EXT_SSNPM,

	KVM_ISA_EXT_ARR(SMSTATEEN),

	KVM_ISA_EXT_ARR(SSAIA),

	KVM_ISA_EXT_ARR(SSCOFPMF),

	KVM_ISA_EXT_ARR(SSNPM),

	KVM_ISA_EXT_ARR(SSTC),

	KVM_ISA_EXT_ARR(SVINVAL),

	KVM_ISA_EXT_ARR(SVNAPOT),
@@ -127,8 +129,10 @@ static bool kvm_riscv_vcpu_isa_disable_allowed(unsigned long ext) 
	case KVM_RISCV_ISA_EXT_C:

	case KVM_RISCV_ISA_EXT_I:

	case KVM_RISCV_ISA_EXT_M:

	case KVM_RISCV_ISA_EXT_SMNPM:

	/* There is not architectural config bit to disable sscofpmf completely */

	case KVM_RISCV_ISA_EXT_SSCOFPMF:

	case KVM_RISCV_ISA_EXT_SSNPM:

	case KVM_RISCV_ISA_EXT_SSTC:

	case KVM_RISCV_ISA_EXT_SVINVAL:

	case KVM_RISCV_ISA_EXT_SVNAPOT: