Commit 18599e93 authored by Jinjie Ruan's avatar Jinjie Ruan Committed by Alexandre Belloni
Browse files

i3c: master: svc: Fix pm_runtime_set_suspended() with runtime pm enabled 



It is not valid to call pm_runtime_set_suspended() for devices
with runtime PM enabled because it returns -EAGAIN if it is enabled
already and working. So, call pm_runtime_disable() before to fix it.

Cc: stable@vger.kernel.org # v5.17
Fixes: 05be23ef ("i3c: master: svc: add runtime pm support")
Reviewed-by: default avatarFrank Li <Frank.Li@nxp.com>
Reviewed-by: default avatarMiquel Raynal <miquel.raynal@bootlin.com>
Signed-off-by: default avatarJinjie Ruan <ruanjinjie@huawei.com>
Link: https://lore.kernel.org/r/20240930091913.2545510-1-ruanjinjie@huawei.com


Signed-off-by: default avatarAlexandre Belloni <alexandre.belloni@bootlin.com>
parent 45357c9b

drivers/i3c/master/svc-i3c-master.c

+1 −1
Original line number Diff line number Diff line
@@ -1891,8 +1891,8 @@ static int svc_i3c_master_probe(struct platform_device *pdev) 
rpm_disable:

	pm_runtime_dont_use_autosuspend(&pdev->dev);

	pm_runtime_put_noidle(&pdev->dev);

	pm_runtime_set_suspended(&pdev->dev);

	pm_runtime_disable(&pdev->dev);

	pm_runtime_set_suspended(&pdev->dev);



err_disable_clks:

	svc_i3c_master_unprepare_clks(master);