Commit 18778b5f authored by Matt Roper's avatar Matt Roper
Browse files

drm/xe: Eliminate usage of TIMESTAMP_OVERRIDE 



Recent discussions with the hardware architects have revealed that
the TIMESTAMP_OVERRIDE register is never expected to hold a valid/useful
value on production hardware.  That register would only get used by
hardware workarounds (although there are none that use it today) or
during early internal hardware testing.

Due to lack of documentation it's not clear exactly what the driver
should be doing if CTC_MODE[0] is set (or even whether that's a setting
that would ever be encountered on real hardware), but it's definitely
not what Xe and i915 have been doing.  So drop the incorrect code trying
to use TIMESTAMP_REGISTER.  If the driver does encounter CTC_MODE[0] in
the wild, we'll print a warning and just continue trying to use the
crystal clock frequency since that's probably less incorrect than what
we're doing today.

Cc: Lucas De Marchi <lucas.demarchi@intel.com>
Cc: Balasubramani Vivekanandan <balasubramani.vivekanandan@intel.com>
Reviewed-by: default avatarLucas De Marchi <lucas.demarchi@intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20250225224908.1671554-2-matthew.d.roper@intel.com


Signed-off-by: default avatarMatt Roper <matthew.d.roper@intel.com>
parent a33c9699

drivers/gpu/drm/xe/regs/xe_regs.h

+0 −4
Original line number Diff line number Diff line
@@ -7,10 +7,6 @@ 


#include "regs/xe_reg_defs.h"



#define TIMESTAMP_OVERRIDE					XE_REG(0x44074)

#define   TIMESTAMP_OVERRIDE_US_COUNTER_DENOMINATOR_MASK	REG_GENMASK(15, 12)

#define   TIMESTAMP_OVERRIDE_US_COUNTER_DIVIDER_MASK		REG_GENMASK(9, 0)



#define GU_CNTL_PROTECTED			XE_REG(0x10100C)

#define   DRIVERINT_FLR_DIS			REG_BIT(31)

drivers/gpu/drm/xe/xe_gt_clock.c

+23 −34
Original line number Diff line number Diff line
@@ -12,25 +12,10 @@ 
#include "xe_assert.h"

#include "xe_device.h"

#include "xe_gt.h"

#include "xe_gt_printk.h"

#include "xe_macros.h"

#include "xe_mmio.h"



static u32 read_reference_ts_freq(struct xe_gt *gt)

{

	u32 ts_override = xe_mmio_read32(&gt->mmio, TIMESTAMP_OVERRIDE);

	u32 base_freq, frac_freq;



	base_freq = REG_FIELD_GET(TIMESTAMP_OVERRIDE_US_COUNTER_DIVIDER_MASK,

				  ts_override) + 1;

	base_freq *= 1000000;



	frac_freq = REG_FIELD_GET(TIMESTAMP_OVERRIDE_US_COUNTER_DENOMINATOR_MASK,

				  ts_override);

	frac_freq = 1000000 / (frac_freq + 1);



	return base_freq + frac_freq;

}



static u32 get_crystal_clock_freq(u32 rpm_config_reg)

{

	const u32 f19_2_mhz = 19200000;
@@ -57,16 +42,21 @@ static u32 get_crystal_clock_freq(u32 rpm_config_reg) 


int xe_gt_clock_init(struct xe_gt *gt)

{

	u32 ctc_reg = xe_mmio_read32(&gt->mmio, CTC_MODE);

	u32 c0 = xe_mmio_read32(&gt->mmio, RPM_CONFIG0);

	u32 freq = 0;



	/* Assuming gen11+ so assert this assumption is correct */

	xe_gt_assert(gt, GRAPHICS_VER(gt_to_xe(gt)) >= 11);



	if (ctc_reg & CTC_SOURCE_DIVIDE_LOGIC) {

		freq = read_reference_ts_freq(gt);

	} else {

		u32 c0 = xe_mmio_read32(&gt->mmio, RPM_CONFIG0);

	/*

	 * CTC_MODE[0] = 1 is definitely not supported for Xe2 and later

	 * platforms.  In theory it could be a valid setting for pre-Xe2

	 * platforms, but there's no documentation on how to properly handle

	 * this case.  Reading TIMESTAMP_OVERRIDE, as the driver attempted in

	 * the past has been confirmed as incorrect by the hardware architects.

	 *

	 * For now just warn if we ever encounter hardware in the wild that

	 * has this setting and move on as if it hadn't been set.

	 */

	if (xe_mmio_read32(&gt->mmio, CTC_MODE) & CTC_SOURCE_DIVIDE_LOGIC)

		xe_gt_warn(gt, "CTC_MODE[0] is set; this is unexpected and undocumented\n");



	freq = get_crystal_clock_freq(c0);
@@ -76,7 +66,6 @@ int xe_gt_clock_init(struct xe_gt *gt) 
	 * increment only every few clock cycle).

	 */

	freq >>= 3 - REG_FIELD_GET(RPM_CONFIG0_CTC_SHIFT_PARAMETER_MASK, c0);

	}



	gt->info.reference_clock = freq;

	return 0;

drivers/gpu/drm/xe/xe_gt_sriov_pf_service.c

+0 −5
Original line number Diff line number Diff line
@@ -114,7 +114,6 @@ static const struct xe_reg tgl_runtime_regs[] = { 
	GT_VEBOX_VDBOX_DISABLE,		/* _MMIO(0x9140) */

	CTC_MODE,			/* _MMIO(0xa26c) */

	HUC_KERNEL_LOAD_INFO,		/* _MMIO(0xc1dc) */

	TIMESTAMP_OVERRIDE,		/* _MMIO(0x44074) */

};



static const struct xe_reg ats_m_runtime_regs[] = {
@@ -127,7 +126,6 @@ static const struct xe_reg ats_m_runtime_regs[] = { 
	XEHP_GT_COMPUTE_DSS_ENABLE,	/* _MMIO(0x9144) */

	CTC_MODE,			/* _MMIO(0xa26c) */

	HUC_KERNEL_LOAD_INFO,		/* _MMIO(0xc1dc) */

	TIMESTAMP_OVERRIDE,		/* _MMIO(0x44074) */

};



static const struct xe_reg pvc_runtime_regs[] = {
@@ -140,7 +138,6 @@ static const struct xe_reg pvc_runtime_regs[] = { 
	XEHPC_GT_COMPUTE_DSS_ENABLE_EXT,/* _MMIO(0x9148) */

	CTC_MODE,			/* _MMIO(0xA26C) */

	HUC_KERNEL_LOAD_INFO,		/* _MMIO(0xc1dc) */

	TIMESTAMP_OVERRIDE,		/* _MMIO(0x44074) */

};



static const struct xe_reg ver_1270_runtime_regs[] = {
@@ -155,7 +152,6 @@ static const struct xe_reg ver_1270_runtime_regs[] = { 
	XEHPC_GT_COMPUTE_DSS_ENABLE_EXT,/* _MMIO(0x9148) */

	CTC_MODE,			/* _MMIO(0xa26c) */

	HUC_KERNEL_LOAD_INFO,		/* _MMIO(0xc1dc) */

	TIMESTAMP_OVERRIDE,		/* _MMIO(0x44074) */

};



static const struct xe_reg ver_2000_runtime_regs[] = {
@@ -173,7 +169,6 @@ static const struct xe_reg ver_2000_runtime_regs[] = { 
	XE2_GT_GEOMETRY_DSS_2,		/* _MMIO(0x9154) */

	CTC_MODE,			/* _MMIO(0xa26c) */

	HUC_KERNEL_LOAD_INFO,		/* _MMIO(0xc1dc) */

	TIMESTAMP_OVERRIDE,		/* _MMIO(0x44074) */

};



static const struct xe_reg ver_3000_runtime_regs[] = {