Commit 18e88509 authored Nov 02, 2024 by Rong Xu Committed by Masahiro Yamada Nov 06, 2024

objtool: Fix unreachable instruction warnings for weak functions



In the presence of both weak and strong function definitions, the
linker drops the weak symbol in favor of a strong symbol, but
leaves the code in place. Code in ignore_unreachable_insn() has
some heuristics to suppress the warning, but it does not work when
-ffunction-sections is enabled.

Suppose function foo has both strong and weak definitions.
Case 1: The strong definition has an annotated section name,
like .init.text. Only the weak definition will be placed into
.text.foo. But since the section has no symbols, there will be no
"hole" in the section.

Case 2: Both sections are without an annotated section name.
Both will be placed into .text.foo section, but there will be only one
symbol (the strong one). If the weak code is before the strong code,
there is no "hole" as it fails to find the right-most symbol before
the offset.

The fix is to use the first node to compute the hole if hole.sym
is empty. If there is no symbol in the section, the first node
will be NULL, in which case, -1 is returned to skip the whole
section.

Co-developed-by: Han Shen <shenhan@google.com>
Signed-off-by: Han Shen <shenhan@google.com>
Signed-off-by: Rong Xu <xur@google.com>
Suggested-by: Sriraman Tallam <tmsriram@google.com>
Suggested-by: Krzysztof Pszeniczny <kpszeniczny@google.com>
Tested-by: Yonghong Song <yonghong.song@linux.dev>
Tested-by: Yabin Cui <yabinc@google.com>
Tested-by: Nathan Chancellor <nathan@kernel.org>
Reviewed-by: Kees Cook <kees@kernel.org>
Acked-by: Josh Poimboeuf <jpoimboe@kernel.org>
Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>

parent 315ad878

tools/objtool/elf.c

+10 −5

Original line number	Diff line number	Diff line
		@@ -224,12 +224,17 @@ int find_symbol_hole_containing(const struct section *sec, unsigned long offset)
		if (n)
		return 0; /* not a hole */

		/* didn't find a symbol for which @offset is after it */
		if (!hole.sym)
		return 0; /* not a hole */

		/* @offset >= sym->offset + sym->len, find symbol after it */
		/*
		* @offset >= sym->offset + sym->len, find symbol after it.
		* When hole.sym is empty, use the first node to compute the hole.
		* If there is no symbol in the section, the first node will be NULL,
		* in which case, -1 is returned to skip the whole section.
		*/
		if (hole.sym)
		n = rb_next(&hole.sym->node);
		else
		n = rb_first_cached(&sec->symbol_tree);

		if (!n)
		return -1; /* until end of address space */