Commit 190cb66a authored by Jaroslav Kysela's avatar Jaroslav Kysela Committed by Takashi Iwai
Browse files

ALSA: pcm: playback silence - remove extra code 



The removed condition handles de facto only one situation where
runtime->silence_filled variable is equal to runtime->buffer_size,
because this variable cannot go over the buffer size. This case is
implicitly caught by the required comparison of the noise distance
with the threshold.

Suggested-by: default avatarOswald Buddenhagen <oswald.buddenhagen@gmx.de>
Signed-off-by: default avatarJaroslav Kysela <perex@perex.cz>
Signed-off-by: default avatarOswald Buddenhagen <oswald.buddenhagen@gmx.de>
Link: https://lore.kernel.org/r/20230505155244.2312199-4-oswald.buddenhagen@gmx.de


Signed-off-by: default avatarTakashi Iwai <tiwai@suse.de>
parent 781b4da6

sound/core/pcm_lib.c

+0 −2
Original line number Diff line number Diff line
@@ -61,8 +61,6 @@ void snd_pcm_playback_silence(struct snd_pcm_substream *substream, snd_pcm_ufram 
				runtime->silence_filled = 0;

			runtime->silence_start = appl_ptr;

		}

		if (runtime->silence_filled >= runtime->buffer_size)

			return;

		/* initialization outside pointer updates */

		if (new_hw_ptr == ULONG_MAX)

			new_hw_ptr = runtime->status->hw_ptr;