Commit 19abb9c2 authored by Wojciech Drewek's avatar Wojciech Drewek Committed by Tony Nguyen
Browse files

ice: Fix recipe read procedure 



When ice driver reads recipes from firmware information about
need_pass_l2 and allow_pass_l2 flags is not stored correctly.
Those flags are stored as one bit each in ice_sw_recipe structure.
Because of that, the result of checking a flag has to be casted to bool.
Note that the need_pass_l2 flag currently works correctly, because
it's stored in the first bit.

Fixes: bccd9bce ("ice: Add guard rule when creating FDB in switchdev")
Reviewed-by: default avatarMarcin Szycik <marcin.szycik@linux.intel.com>
Reviewed-by: default avatarPrzemek Kitszel <przemyslaw.kitszel@intel.com>
Signed-off-by: default avatarWojciech Drewek <wojciech.drewek@intel.com>
Reviewed-by: default avatarSimon Horman <horms@kernel.org>
Tested-by: default avatarSujai Buvaneswaran <sujai.buvaneswaran@intel.com>
Signed-off-by: default avatarTony Nguyen <anthony.l.nguyen@intel.com>
parent 6ebbe97a

drivers/net/ethernet/intel/ice/ice_switch.c

+4 −4
Original line number Diff line number Diff line
@@ -2400,10 +2400,10 @@ ice_get_recp_frm_fw(struct ice_hw *hw, struct ice_sw_recipe *recps, u8 rid, 


		/* Propagate some data to the recipe database */

		recps[idx].priority = root_bufs.content.act_ctrl_fwd_priority;

		recps[idx].need_pass_l2 = root_bufs.content.act_ctrl &

					  ICE_AQ_RECIPE_ACT_NEED_PASS_L2;

		recps[idx].allow_pass_l2 = root_bufs.content.act_ctrl &

					   ICE_AQ_RECIPE_ACT_ALLOW_PASS_L2;

		recps[idx].need_pass_l2 = !!(root_bufs.content.act_ctrl &

					     ICE_AQ_RECIPE_ACT_NEED_PASS_L2);

		recps[idx].allow_pass_l2 = !!(root_bufs.content.act_ctrl &

					      ICE_AQ_RECIPE_ACT_ALLOW_PASS_L2);

		bitmap_zero(recps[idx].res_idxs, ICE_MAX_FV_WORDS);

		if (root_bufs.content.result_indx & ICE_AQ_RECIPE_RESULT_EN) {

			set_bit(root_bufs.content.result_indx &