Commit 19dbdbfb authored by Colin Ian King's avatar Colin Ian King Committed by Rob Clark
Browse files

drm/msm/a5xx: remove null pointer check on pdev 



The call chain on a5xx_gpu_init is such that pdev is not going to be
null, so the null check on pdev can be removed. This also cleans up
a static analysis warning where pdev is dereferenced before the null
check which cannot actually occur.

Signed-off-by: default avatarColin Ian King <colin.i.king@gmail.com>
Reviewed-by: default avatarAkhil P Oommen <quic_akhilpo@quicinc.com>
Reviewed-by: default avatarKonrad Dybcio <konrad.dybcio@oss.qualcomm.com>
Patchwork: https://patchwork.freedesktop.org/patch/624180/


Signed-off-by: default avatarRob Clark <robdclark@chromium.org>
parent 3a47f4b4

drivers/gpu/drm/msm/adreno/a5xx_gpu.c

+0 −5
Original line number Diff line number Diff line
@@ -1760,11 +1760,6 @@ struct msm_gpu *a5xx_gpu_init(struct drm_device *dev) 
	unsigned int nr_rings;

	int ret;



	if (!pdev) {

		DRM_DEV_ERROR(dev->dev, "No A5XX device is defined\n");

		return ERR_PTR(-ENXIO);

	}



	a5xx_gpu = kzalloc(sizeof(*a5xx_gpu), GFP_KERNEL);

	if (!a5xx_gpu)

		return ERR_PTR(-ENOMEM);