Commit 19de03b3 authored by Damien Le Moal's avatar Damien Le Moal Committed by Jens Axboe
Browse files

block: make REQ_OP_ZONE_OPEN a write operation 



A REQ_OP_OPEN_ZONE request changes the condition of a sequential zone of
a zoned block device to the explicitly open condition
(BLK_ZONE_COND_EXP_OPEN). As such, it should be considered a write
operation.

Change this operation code to be an odd number to reflect this. The
following operation numbers are changed to keep the numbering compact.

No problems were reported without this change as this operation has no
data. However, this unifies the zone operation to reflect that they
modify the device state and also allows strengthening checks in the
block layer, e.g. checking if this operation is not issued against a
read-only device.

Fixes: 6c1b1da5 ("block: add zone open, close and finish operations")
Cc: stable@vger.kernel.org
Signed-off-by: default avatarDamien Le Moal <dlemoal@kernel.org>
Reviewed-by: default avatarChaitanya Kulkarni <kch@nvidia.com>
Reviewed-by: default avatarChristoph Hellwig <hch@lst.de>
Reviewed-by: default avatarJohannes Thumshirn <johannes.thumshirn@wdc.com>
Signed-off-by: default avatarJens Axboe <axboe@kernel.dk>
parent 12a1c935

include/linux/blk_types.h

+5 −5
Original line number Diff line number Diff line
@@ -341,15 +341,15 @@ enum req_op { 
	/* write the zero filled sector many times */

	REQ_OP_WRITE_ZEROES	= (__force blk_opf_t)9,

	/* Open a zone */

	REQ_OP_ZONE_OPEN	= (__force blk_opf_t)10,

	REQ_OP_ZONE_OPEN	= (__force blk_opf_t)11,

	/* Close a zone */

	REQ_OP_ZONE_CLOSE	= (__force blk_opf_t)11,

	REQ_OP_ZONE_CLOSE	= (__force blk_opf_t)13,

	/* Transition a zone to full */

	REQ_OP_ZONE_FINISH	= (__force blk_opf_t)13,

	REQ_OP_ZONE_FINISH	= (__force blk_opf_t)15,

	/* reset a zone write pointer */

	REQ_OP_ZONE_RESET	= (__force blk_opf_t)15,

	REQ_OP_ZONE_RESET	= (__force blk_opf_t)17,

	/* reset all the zone present on the device */

	REQ_OP_ZONE_RESET_ALL	= (__force blk_opf_t)17,

	REQ_OP_ZONE_RESET_ALL	= (__force blk_opf_t)19,



	/* Driver private requests */

	REQ_OP_DRV_IN		= (__force blk_opf_t)34,