Commit 19f73e93 authored by Ilpo Järvinen's avatar Ilpo Järvinen Committed by Bjorn Helgaas
Browse files

PCI: Improve pdev_sort_resources() warning message 

Use pci_resource_name() helper in pdev_sort_resources() to print resources
in user-friendly format. Also replace the vague "bogus alignment" with a
more precise explanation of the problem.

Link: https://lore.kernel.org/r/20241017095545.1424-1-ilpo.jarvinen@linux.intel.com


Signed-off-by: default avatarIlpo Järvinen <ilpo.jarvinen@linux.intel.com>
Signed-off-by: default avatarBjorn Helgaas <bhelgaas@google.com>
Reviewed-by: default avatarPhilipp Stanner <pstanner@redhat.com>
parent e3bdd2dd

drivers/pci/setup-bus.c

+3 −2
Original line number Diff line number Diff line
@@ -134,6 +134,7 @@ static void pdev_sort_resources(struct pci_dev *dev, struct list_head *head) 
	int i;



	pci_dev_for_each_resource(dev, r, i) {

		const char *r_name = pci_resource_name(dev, i);

		struct pci_dev_resource *dev_res, *tmp;

		resource_size_t r_align;

		struct list_head *n;
@@ -146,8 +147,8 @@ static void pdev_sort_resources(struct pci_dev *dev, struct list_head *head) 


		r_align = pci_resource_alignment(dev, r);

		if (!r_align) {

			pci_warn(dev, "BAR %d: %pR has bogus alignment\n",

				 i, r);

			pci_warn(dev, "%s %pR: alignment must not be zero\n",

				 r_name, r);

			continue;

		}