Commit 1ac98d64 authored by Krzysztof Kozlowski's avatar Krzysztof Kozlowski Committed by Bjorn Andersson
Browse files

soc: qcom: pmic_glink: Drop redundant pg assignment before taking lock 

Commit e9f826b0 ("soc: qcom: pmic_glink: simplify locking with
guard()") was on top of a fix [1] which was moving the 'pg =
__pmic_glink' assignment into the critical section.  Unfortunately the
actual fix was not applied and instead rebased version of the next patch
got in.  The resulting code is in general correct, but now there is a
duplicated assignment 'pg = __pmic_glink'.

[1] https://lore.kernel.org/all/20240822164815.230167-1-krzysztof.kozlowski@linaro.org/



Fixes: e9f826b0 ("soc: qcom: pmic_glink: simplify locking with guard()")
Signed-off-by: default avatarKrzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Link: https://lore.kernel.org/r/20250111172326.101779-1-krzysztof.kozlowski@linaro.org


Signed-off-by: default avatarBjorn Andersson <andersson@kernel.org>
parent 2014c95a

drivers/soc/qcom/pmic_glink.c

+1 −1
Original line number Diff line number Diff line
@@ -233,7 +233,7 @@ static void pmic_glink_pdr_callback(int state, char *svc_path, void *priv) 


static int pmic_glink_rpmsg_probe(struct rpmsg_device *rpdev)

{

	struct pmic_glink *pg = __pmic_glink;

	struct pmic_glink *pg;



	guard(mutex)(&__pmic_glink_lock);

	pg = __pmic_glink;