Commit 1c000dca authored by Thomas Gleixner's avatar Thomas Gleixner
Browse files

irqchip/irq-msi-lib: Optionally set default irq_eoi()/irq_ack() 



msi_lib_init_dev_msi_info() sets the default irq_eoi()/irq_ack() callbacks
unconditionally. This is correct for all existing users, but prevents the
IMSIC driver to be moved to the MSI library implementation.

Introduce chip_flags in struct msi_parent_ops, which instruct the library
to selectively set the callbacks depending on the flags, and update all
current users to set them.

Signed-off-by: default avatarThomas Gleixner <tglx@linutronix.de>
Signed-off-by: default avatarAnup Patel <apatel@ventanamicro.com>
Signed-off-by: default avatarThomas Gleixner <tglx@linutronix.de>
Link: https://lore.kernel.org/all/20250217085657.789309-3-apatel@ventanamicro.com
parent 999f458c

drivers/irqchip/irq-gic-v2m.c

+1 −0
Original line number Diff line number Diff line
@@ -255,6 +255,7 @@ static void __init gicv2m_teardown(void) 
static struct msi_parent_ops gicv2m_msi_parent_ops = {

	.supported_flags	= GICV2M_MSI_FLAGS_SUPPORTED,

	.required_flags		= GICV2M_MSI_FLAGS_REQUIRED,

	.chip_flags		= MSI_CHIP_FLAG_SET_EOI | MSI_CHIP_FLAG_SET_ACK,

	.bus_select_token	= DOMAIN_BUS_NEXUS,

	.bus_select_mask	= MATCH_PCI_MSI | MATCH_PLATFORM_MSI,

	.prefix			= "GICv2m-",

drivers/irqchip/irq-gic-v3-its-msi-parent.c

+1 −0
Original line number Diff line number Diff line
@@ -203,6 +203,7 @@ static bool its_init_dev_msi_info(struct device *dev, struct irq_domain *domain, 
const struct msi_parent_ops gic_v3_its_msi_parent_ops = {

	.supported_flags	= ITS_MSI_FLAGS_SUPPORTED,

	.required_flags		= ITS_MSI_FLAGS_REQUIRED,

	.chip_flags		= MSI_CHIP_FLAG_SET_EOI | MSI_CHIP_FLAG_SET_ACK,

	.bus_select_token	= DOMAIN_BUS_NEXUS,

	.bus_select_mask	= MATCH_PCI_MSI | MATCH_PLATFORM_MSI,

	.prefix			= "ITS-",

drivers/irqchip/irq-gic-v3-mbi.c

+1 −0
Original line number Diff line number Diff line
@@ -201,6 +201,7 @@ static bool mbi_init_dev_msi_info(struct device *dev, struct irq_domain *domain, 
static const struct msi_parent_ops gic_v3_mbi_msi_parent_ops = {

	.supported_flags	= MBI_MSI_FLAGS_SUPPORTED,

	.required_flags		= MBI_MSI_FLAGS_REQUIRED,

	.chip_flags		= MSI_CHIP_FLAG_SET_EOI | MSI_CHIP_FLAG_SET_ACK,

	.bus_select_token	= DOMAIN_BUS_NEXUS,

	.bus_select_mask	= MATCH_PCI_MSI | MATCH_PLATFORM_MSI,

	.prefix			= "MBI-",

drivers/irqchip/irq-imx-mu-msi.c

+1 −0
Original line number Diff line number Diff line
@@ -214,6 +214,7 @@ static void imx_mu_msi_irq_handler(struct irq_desc *desc) 
static const struct msi_parent_ops imx_mu_msi_parent_ops = {

	.supported_flags	= IMX_MU_MSI_FLAGS_SUPPORTED,

	.required_flags		= IMX_MU_MSI_FLAGS_REQUIRED,

	.chip_flags		= MSI_CHIP_FLAG_SET_EOI | MSI_CHIP_FLAG_SET_ACK,

	.bus_select_token       = DOMAIN_BUS_NEXUS,

	.bus_select_mask	= MATCH_PLATFORM_MSI,

	.prefix			= "MU-MSI-",

drivers/irqchip/irq-loongson-pch-msi.c

+1 −0
Original line number Diff line number Diff line
@@ -146,6 +146,7 @@ static const struct irq_domain_ops pch_msi_middle_domain_ops = { 
static struct msi_parent_ops pch_msi_parent_ops = {

	.required_flags		= PCH_MSI_FLAGS_REQUIRED,

	.supported_flags	= PCH_MSI_FLAGS_SUPPORTED,

	.chip_flags		= MSI_CHIP_FLAG_SET_EOI | MSI_CHIP_FLAG_SET_ACK,

	.bus_select_mask	= MATCH_PCI_MSI,

	.bus_select_token	= DOMAIN_BUS_NEXUS,

	.prefix			= "PCH-",