Commit 1c0353a6 authored by Jakub Kicinski's avatar Jakub Kicinski
Browse files

selftests: net: speed up pmtu.sh by avoiding unnecessary cleanup 



The pmtu test takes nearly an hour when run on a debug kernel
(10min on a normal kernel, so the debug slow down is quite significant).
NIPA tries to ensure all results are delivered by a certain deadline
so this prevents it from retrying the test in case of a flake.

Looks like one of the slowest operations in the test is calling out
to ./openvswitch/ovs-dpctl.py to remove potential leftover OvS interfaces.
Check whether the interfaces exist in the first place in sysfs,
since it can be done directly in bash it is very fast.

This should save us around 20-30% of the test runtime.

Reviewed-by: default avatarSimon Horman <horms@kernel.org>
Link: https://patch.msgid.link/20250906214535.3204785-1-kuba@kernel.org


Signed-off-by: default avatarJakub Kicinski <kuba@kernel.org>
parent a12fd5c3

tools/testing/selftests/net/pmtu.sh

+5 −4
Original line number Diff line number Diff line
@@ -1089,10 +1089,11 @@ cleanup() { 


	cleanup_all_ns



	ip link del veth_A-C		2>/dev/null

	ip link del veth_A-R1		2>/dev/null

	cleanup_del_ovs_internal

	cleanup_del_ovs_vswitchd

	[ -e "/sys/class/net/veth_A-C"  ] && ip link del veth_A-C

	[ -e "/sys/class/net/veth_A-R1" ] && ip link del veth_A-R1

	[ -e "/sys/class/net/ovs_br0"   ] && cleanup_del_ovs_internal

	[ -e "/sys/class/net/ovs_br0"   ] && cleanup_del_ovs_vswitchd



	rm -f "$tmpoutfile"

}