Commit 1c2e7039 authored by Praveen Talari's avatar Praveen Talari Committed by Linus Walleij
Browse files

pinctrl: qcom: msm: Fix deadlock in pinmux configuration 



Replace disable_irq() with disable_irq_nosync() in msm_pinmux_set_mux()
to prevent deadlock when wakeup IRQ is triggered on the same
GPIO being reconfigured.

The issue occurs when a wakeup IRQ is triggered on a GPIO and the IRQ
handler attempts to reconfigure the same GPIO's pinmux. In this scenario,
msm_pinmux_set_mux() calls disable_irq() which waits for the currently
running IRQ handler to complete, creating a circular dependency that
results in deadlock.

Using disable_irq_nosync() avoids waiting for the IRQ handler to
complete, preventing the deadlock condition while still properly
disabling the interrupt during pinmux reconfiguration.

Suggested-by: default avatarPrasad Sodagudi <prasad.sodagudi@oss.qualcomm.com>
Signed-off-by: default avatarPraveen Talari <praveen.talari@oss.qualcomm.com>
Reviewed-by: default avatarBjorn Andersson <andersson@kernel.org>
Signed-off-by: default avatarLinus Walleij <linus.walleij@linaro.org>
parent 9b07cdf8

drivers/pinctrl/qcom/pinctrl-msm.c

+1 −1
Original line number Diff line number Diff line
@@ -189,7 +189,7 @@ static int msm_pinmux_set_mux(struct pinctrl_dev *pctldev, 
	 */

	if (d && i != gpio_func &&

	    !test_and_set_bit(d->hwirq, pctrl->disabled_for_mux))

		disable_irq(irq);

		disable_irq_nosync(irq);



	raw_spin_lock_irqsave(&pctrl->lock, flags);