Unverified Commit 1c9d30d3 authored by Dmitry Torokhov's avatar Dmitry Torokhov Committed by Ilpo Järvinen
Browse files

platform/x86: barco-p50-gpio: normalize return value of gpio_get 



The GPIO get callback is expected to return 0 or 1 (or a negative error
code). Ensure that the value returned by p50_gpio_get() is normalized
to the [0, 1] range.

Fixes: 86ef402d ("gpiolib: sanitize the return value of gpio_chip::get()")
Reviewed-by: default avatarLinus Walleij <linusw@kernel.org>
Signed-off-by: default avatarDmitry Torokhov <dmitry.torokhov@gmail.com>
Reviewed-by: default avatarBartosz Golaszewski <bartosz.golaszewski@oss.qualcomm.com>
Link: https://patch.msgid.link/20260318-barco-p50-gpio-set-v2-1-c0a4a6416163@gmail.com


Reviewed-by: default avatarIlpo Järvinen <ilpo.jarvinen@linux.intel.com>
Signed-off-by: default avatarIlpo Järvinen <ilpo.jarvinen@linux.intel.com>
parent 8786af77

drivers/platform/x86/barco-p50-gpio.c

+4 −1
Original line number Diff line number Diff line
@@ -275,8 +275,11 @@ static int p50_gpio_get(struct gpio_chip *gc, unsigned int offset) 
	mutex_lock(&p50->lock);



	ret = p50_send_mbox_cmd(p50, P50_MBOX_CMD_READ_GPIO, gpio_params[offset], 0);

	if (ret == 0)

	if (ret == 0) {

		ret = p50_read_mbox_reg(p50, P50_MBOX_REG_DATA);

		if (ret >= 0)

			ret = !!ret;

	}



	mutex_unlock(&p50->lock);