Commit 1d38eb7f authored by Joe Hattori's avatar Joe Hattori Committed by Viresh Kumar
Browse files

OPP: OF: Fix an OF node leak in _opp_add_static_v2() 



_opp_add_static_v2() leaks the obtained OF node reference when
_of_opp_alloc_required_opps() fails. Add an of_node_put() call in the
error path.

Fixes: 3466ea2c ("OPP: Don't drop opp->np reference while it is still in use")
Signed-off-by: default avatarJoe Hattori <joe@pf.is.s.u-tokyo.ac.jp>
Signed-off-by: default avatarViresh Kumar <viresh.kumar@linaro.org>
parent b44b9bc7

drivers/opp/of.c

+3 −1
Original line number Diff line number Diff line
@@ -926,7 +926,7 @@ static struct dev_pm_opp *_opp_add_static_v2(struct opp_table *opp_table, 


	ret = _of_opp_alloc_required_opps(opp_table, new_opp);

	if (ret)

		goto free_opp;

		goto put_node;



	if (!of_property_read_u32(np, "clock-latency-ns", &val))

		new_opp->clock_latency_ns = val;
@@ -976,6 +976,8 @@ static struct dev_pm_opp *_opp_add_static_v2(struct opp_table *opp_table, 


free_required_opps:

	_of_opp_free_required_opps(opp_table, new_opp);

put_node:

	of_node_put(np);

free_opp:

	_opp_free(new_opp);