Commit 1d811438 authored by Wang Yugui's avatar Wang Yugui Committed by Keith Busch
Browse files

nvme: add rotational support 



Rotational devices, such as hard-drives, can be detected using
the rotational bit in the namespace independent identify namespace
data structure. Make the bit visible to the block layer through the
rotational queue setting.

Signed-off-by: default avatarWang Yugui <wangyugui@e16-tech.com>
Reviewed-by: default avatarMatias Bjørling <matias.bjorling@wdc.com>
Reviewed-by: default avatarMartin K. Petersen <martin.petersen@oracle.com>
Reviewed-by: default avatarHannes Reinecke <hare@suse.de>
Reviewed-by: default avatarChristoph Hellwig <hch@lst.de>
Signed-off-by: default avatarKeith Busch <kbusch@kernel.org>
parent ee9f36db

drivers/nvme/host/core.c

+6 −0
Original line number Diff line number Diff line
@@ -42,6 +42,7 @@ struct nvme_ns_info { 
	bool is_readonly;

	bool is_ready;

	bool is_removed;

	bool is_rotational;

};



unsigned int admin_timeout = 60;
@@ -1615,6 +1616,7 @@ static int nvme_ns_info_from_id_cs_indep(struct nvme_ctrl *ctrl, 
		info->is_shared = id->nmic & NVME_NS_NMIC_SHARED;

		info->is_readonly = id->nsattr & NVME_NS_ATTR_RO;

		info->is_ready = id->nstat & NVME_NSTAT_NRDY;

		info->is_rotational = id->nsfeat & NVME_NS_ROTATIONAL;

	}

	kfree(id);

	return ret;
@@ -2162,6 +2164,9 @@ static int nvme_update_ns_info_block(struct nvme_ns *ns, 
	else

		lim.features &= ~(BLK_FEAT_WRITE_CACHE | BLK_FEAT_FUA);



	if (info->is_rotational)

		lim.features |= BLK_FEAT_ROTATIONAL;



	/*

	 * Register a metadata profile for PI, or the plain non-integrity NVMe

	 * metadata masquerading as Type 0 if supported, otherwise reject block
@@ -3608,6 +3613,7 @@ static struct nvme_ns_head *nvme_alloc_ns_head(struct nvme_ctrl *ctrl, 
	head->ns_id = info->nsid;

	head->ids = info->ids;

	head->shared = info->is_shared;

	head->rotational = info->is_rotational;

	ratelimit_state_init(&head->rs_nuse, 5 * HZ, 1);

	ratelimit_set_flags(&head->rs_nuse, RATELIMIT_MSG_ON_RELEASE);

	kref_init(&head->ref);

drivers/nvme/host/nvme.h

+1 −0
Original line number Diff line number Diff line
@@ -474,6 +474,7 @@ struct nvme_ns_head { 
	struct list_head	entry;

	struct kref		ref;

	bool			shared;

	bool			rotational;

	bool			passthru_err_log_enabled;

	struct nvme_effects_log *effects;

	u64			nuse;