Commit 1dd60958 authored by André Draszik's avatar André Draszik Committed by Alexandre Belloni
Browse files

rtc: s5m: switch to devm_device_init_wakeup 



To release memory allocated by device_init_wakeup(true), drivers have
to call device_init_wakeup(false) in error paths and unbind.

Switch to the new devres managed version devm_device_init_wakeup() to
plug this memleak.

Reviewed-by: default avatarKrzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Signed-off-by: default avatarAndré Draszik <andre.draszik@linaro.org>
Link: https://lore.kernel.org/r/20250409-s2mpg10-v4-29-d66d5f39b6bf@linaro.org


Signed-off-by: default avatarAlexandre Belloni <alexandre.belloni@bootlin.com>
parent 972a3b47

drivers/rtc/rtc-s5m.c

+5 −1
Original line number Diff line number Diff line
@@ -779,7 +779,11 @@ static int s5m_rtc_probe(struct platform_device *pdev) 
			return dev_err_probe(&pdev->dev, ret,

					     "Failed to request alarm IRQ %d\n",

					     info->irq);

		device_init_wakeup(&pdev->dev, true);



		ret = devm_device_init_wakeup(&pdev->dev);

		if (ret < 0)

			return dev_err_probe(&pdev->dev, ret,

					     "Failed to init wakeup\n");

	}



	if (of_device_is_system_power_controller(pdev->dev.parent->of_node) &&