Commit 1e111c4b authored by Yang Xiuwei's avatar Yang Xiuwei Committed by Martin K. Petersen
Browse files

scsi: sd: fix missing put_disk() when device_add(&disk_dev) fails 



If device_add(&sdkp->disk_dev) fails, put_device() runs
scsi_disk_release(), which frees the scsi_disk but leaves the gendisk
referenced. The device_add_disk() error path in sd_probe() calls
put_disk(gd); call put_disk(gd) here to mirror that cleanup.

Fixes: 265dfe8e ("scsi: sd: Free scsi_disk device via put_device()")
Cc: stable@vger.kernel.org
Reviewed-by: default avatarJohn Garry <john.g.garry@oracle.com>
Signed-off-by: default avatarYang Xiuwei <yangxiuwei@kylinos.cn>
Link: https://patch.msgid.link/20260330014952.152776-1-yangxiuwei@kylinos.cn


Signed-off-by: default avatarMartin K. Petersen <martin.petersen@oracle.com>
parent 1a2f6197

drivers/scsi/sd.c

+1 −0
Original line number Diff line number Diff line
@@ -4061,6 +4061,7 @@ static int sd_probe(struct scsi_device *sdp) 
	error = device_add(&sdkp->disk_dev);

	if (error) {

		put_device(&sdkp->disk_dev);

		put_disk(gd);

		goto out;

	}