Commit 1f1b673c authored by Ville Syrjälä's avatar Ville Syrjälä
Browse files

drm/i915: Warn if someone tries to use intel_set_transcoder_timings*() on DSI outputs 



intel_set_transcoder_timings*() aren't currently suitable for DSI.
Warn if someone accidentally calls them in such cases.

Cc: Paz Zcharya <pazz@chromium.org>
Signed-off-by: default avatarVille Syrjälä <ville.syrjala@linux.intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20250116201637.22486-5-ville.syrjala@linux.intel.com


Reviewed-by: default avatarJani Nikula <jani.nikula@intel.com>
parent d6d4dc22

drivers/gpu/drm/i915/display/intel_display.c

+4 −0
Original line number Diff line number Diff line
@@ -2837,6 +2837,8 @@ static void intel_set_transcoder_timings(const struct intel_crtc_state *crtc_sta 
	u32 crtc_vdisplay, crtc_vtotal, crtc_vblank_start, crtc_vblank_end;

	int vsyncshift = 0;



	drm_WARN_ON(&dev_priv->drm, transcoder_is_dsi(cpu_transcoder));



	/* We need to be careful not to changed the adjusted mode, for otherwise

	 * the hw state checker will get angry at the mismatch. */

	crtc_vdisplay = adjusted_mode->crtc_vdisplay;
@@ -2918,6 +2920,8 @@ static void intel_set_transcoder_timings_lrr(const struct intel_crtc_state *crtc 
	const struct drm_display_mode *adjusted_mode = &crtc_state->hw.adjusted_mode;

	u32 crtc_vdisplay, crtc_vtotal, crtc_vblank_start, crtc_vblank_end;



	drm_WARN_ON(&dev_priv->drm, transcoder_is_dsi(cpu_transcoder));



	crtc_vdisplay = adjusted_mode->crtc_vdisplay;

	crtc_vtotal = adjusted_mode->crtc_vtotal;

	crtc_vblank_start = adjusted_mode->crtc_vblank_start;