Commit 1fb5cf0d authored by Johan Hovold's avatar Johan Hovold Committed by Bjorn Andersson
Browse files

Revert "arm64: dts: qcom: x1e78100-t14s: enable otg on usb-c ports" 



This reverts commit 1a48dd7b.

A recent change enabling OTG mode on the Lenovo ThinkPad T14s USB-C
ports can break SuperSpeed device hotplugging. The host controller is
enumerated, but the device is not:

	xhci-hcd xhci-hcd.5.auto: xHCI Host Controller
	xhci-hcd xhci-hcd.5.auto: new USB bus registered, assigned bus number 3
	xhci-hcd xhci-hcd.5.auto: hcc params 0x0110ffc5 hci version 0x110 quirks 0x000080a000000810
	xhci-hcd xhci-hcd.5.auto: irq 247, io mem 0x0a800000
	xhci-hcd xhci-hcd.5.auto: xHCI Host Controller
	xhci-hcd xhci-hcd.5.auto: new USB bus registered, assigned bus number 4
	xhci-hcd xhci-hcd.5.auto: Host supports USB 3.1 Enhanced SuperSpeed
	hub 3-0:1.0: USB hub found
	hub 3-0:1.0: 1 port detected
	hub 4-0:1.0: USB hub found
	hub 4-0:1.0: 1 port detected

Once this happens on either of the two ports, no amount of disconnecting
and reconnecting makes the SuperSpeed device be enumerated, while
FullSpeed device enumeration still works.

With retimer (and orientation detection) support not even merged yet,
let's revert at least until we have stable host mode in mainline.

Fixes: 1a48dd7b ("arm64: dts: qcom: x1e78100-t14s: enable otg on usb-c ports")
Cc: Jonathan Marek <jonathan@marek.ca>
Signed-off-by: default avatarJohan Hovold <johan+linaro@kernel.org>
Reviewed-by: default avatarAbel Vesa <abel.vesa@linaro.org>
Link: https://lore.kernel.org/r/20241206172402.20724-1-johan+linaro@kernel.org


Signed-off-by: default avatarBjorn Andersson <andersson@kernel.org>
parent e60b14f4

arch/arm64/boot/dts/qcom/x1e78100-lenovo-thinkpad-t14s.dts

+8 −0
Original line number Diff line number Diff line
@@ -773,6 +773,10 @@ &usb_1_ss0 { 
	status = "okay";

};



&usb_1_ss0_dwc3 {

	dr_mode = "host";

};



&usb_1_ss0_dwc3_hs {

	remote-endpoint = <&pmic_glink_ss0_hs_in>;

};
@@ -801,6 +805,10 @@ &usb_1_ss1 { 
	status = "okay";

};



&usb_1_ss1_dwc3 {

	dr_mode = "host";

};



&usb_1_ss1_dwc3_hs {

	remote-endpoint = <&pmic_glink_ss1_hs_in>;

};