Commit 1fe4f1bf authored by Heiner Kallweit's avatar Heiner Kallweit Committed by Lee Jones
Browse files

leds: trigger: netdev: Remove not needed call to led_set_brightness in deactivate 



led_trigger_set() is the only caller of the deactivate() callback,
and it calls led_set_brightness(LED_OFF) anyway after deactivate().
So we can remove the call here.

Signed-off-by: default avatarHeiner Kallweit <hkallweit1@gmail.com>
Link: https://lore.kernel.org/r/8dc929e7-8e14-4c85-aa28-9c5fe2620f52@gmail.com


Signed-off-by: default avatarLee Jones <lee@kernel.org>
parent 77b9f2d6

drivers/leds/trigger/ledtrig-netdev.c

+0 −2
Original line number Diff line number Diff line
@@ -724,8 +724,6 @@ static void netdev_trig_deactivate(struct led_classdev *led_cdev) 


	cancel_delayed_work_sync(&trigger_data->work);



	led_set_brightness(led_cdev, LED_OFF);



	dev_put(trigger_data->net_dev);



	kfree(trigger_data);