Commit 20040b2a authored by Ivan Vecera's avatar Ivan Vecera Committed by Paolo Abeni
Browse files

dpll: export __dpll_device_change_ntf() for use under dpll_lock 



Export __dpll_device_change_ntf() so that drivers can send device
change notifications from within device callbacks, which are already
called under dpll_lock. Using dpll_device_change_ntf() in that
context would deadlock.

Add lockdep_assert_held() to catch misuse without the lock held.

Signed-off-by: default avatarIvan Vecera <ivecera@redhat.com>
Reviewed-by: default avatarJiri Pirko <jiri@nvidia.com>
Link: https://patch.msgid.link/20260526074525.1451008-2-ivecera@redhat.com


Signed-off-by: default avatarPaolo Abeni <pabeni@redhat.com>
parent 1af2af70

drivers/dpll/dpll_netlink.c

+11 −2
Original line number Diff line number Diff line
@@ -829,12 +829,21 @@ int dpll_device_delete_ntf(struct dpll_device *dpll) 
	return dpll_device_event_send(DPLL_CMD_DEVICE_DELETE_NTF, dpll);

}



static int

__dpll_device_change_ntf(struct dpll_device *dpll)

/**

 * __dpll_device_change_ntf - notify that the dpll device has been changed

 * @dpll: registered dpll pointer

 *

 * Context: caller must hold dpll_lock. Suitable for use inside device

 *          callbacks which are already invoked under dpll_lock.

 * Return: 0 if succeeds, error code otherwise.

 */

int __dpll_device_change_ntf(struct dpll_device *dpll)

{

	lockdep_assert_held(&dpll_lock);

	dpll_device_notify(dpll, DPLL_DEVICE_CHANGED);

	return dpll_device_event_send(DPLL_CMD_DEVICE_CHANGE_NTF, dpll);

}

EXPORT_SYMBOL_GPL(__dpll_device_change_ntf);



/**

 * dpll_device_change_ntf - notify that the dpll device has been changed

include/linux/dpll.h

+1 −0
Original line number Diff line number Diff line
@@ -284,6 +284,7 @@ void dpll_pin_on_pin_unregister(struct dpll_pin *parent, struct dpll_pin *pin, 
int dpll_pin_ref_sync_pair_add(struct dpll_pin *pin,

			       struct dpll_pin *ref_sync_pin);



int __dpll_device_change_ntf(struct dpll_device *dpll);

int dpll_device_change_ntf(struct dpll_device *dpll);



int __dpll_pin_change_ntf(struct dpll_pin *pin);