Commit 2055272e authored by Dan Carpenter's avatar Dan Carpenter Committed by Jakub Kicinski
Browse files

rtase: Fix a check for error in rtase_alloc_msix() 



The pci_irq_vector() function never returns zero.  It returns negative
error codes or a positive non-zero IRQ number.  Fix the error checking to
test for negatives.

Fixes: a36e9f5c ("rtase: Add support for a pci table in this module")
Signed-off-by: default avatarDan Carpenter <dan.carpenter@linaro.org>
Reviewed-by: default avatarSimon Horman <horms@kernel.org>
Reviewed-by: default avatarKalesh AP <kalesh-anakkur.purayil@broadcom.com>
Link: https://patch.msgid.link/f2ecc88d-af13-4651-9820-7cc665230019@stanley.mountain


Signed-off-by: default avatarJakub Kicinski <kuba@kernel.org>
parent 426046e2

drivers/net/ethernet/realtek/rtase/rtase_main.c

+1 −1
Original line number Diff line number Diff line
@@ -1827,7 +1827,7 @@ static int rtase_alloc_msix(struct pci_dev *pdev, struct rtase_private *tp) 


	for (i = 0; i < tp->int_nums; i++) {

		irq = pci_irq_vector(pdev, i);

		if (!irq) {

		if (irq < 0) {

			pci_disable_msix(pdev);

			return irq;

		}