Unverified Commit 20b78183 authored by Christoph Hellwig's avatar Christoph Hellwig Committed by Christian Brauner
Browse files

fs: remove inode_update_time 



The only external user is gone now, open code it in the two VFS
callers.

Signed-off-by: default avatarChristoph Hellwig <hch@lst.de>
Link: https://patch.msgid.link/20260108141934.2052404-2-hch@lst.de


Reviewed-by: default avatarJan Kara <jack@suse.cz>
Reviewed-by: default avatarChaitanya Kulkarni <kch@nvidia.com>
Reviewed-by: default avatarJeff Layton <jlayton@kernel.org>
Signed-off-by: default avatarChristian Brauner <brauner@kernel.org>
parent 8f0b4cce

fs/inode.c

+8 −15
Original line number Diff line number Diff line
@@ -2157,19 +2157,6 @@ int generic_update_time(struct inode *inode, int flags) 
}

EXPORT_SYMBOL(generic_update_time);



/*

 * This does the actual work of updating an inodes time or version.  Must have

 * had called mnt_want_write() before calling this.

 */

int inode_update_time(struct inode *inode, int flags)

{

	if (inode->i_op->update_time)

		return inode->i_op->update_time(inode, flags);

	generic_update_time(inode, flags);

	return 0;

}

EXPORT_SYMBOL(inode_update_time);



/**

 *	atime_needs_update	-	update the access time

 *	@path: the &struct path to update
@@ -2237,7 +2224,10 @@ void touch_atime(const struct path *path) 
	 * We may also fail on filesystems that have the ability to make parts

	 * of the fs read only, e.g. subvolumes in Btrfs.

	 */

	inode_update_time(inode, S_ATIME);

	if (inode->i_op->update_time)

		inode->i_op->update_time(inode, S_ATIME);

	else

		generic_update_time(inode, S_ATIME);

	mnt_put_write_access(mnt);

skip_update:

	sb_end_write(inode->i_sb);
@@ -2392,7 +2382,10 @@ static int file_update_time_flags(struct file *file, unsigned int flags) 


	if (mnt_get_write_access_file(file))

		return 0;

	ret = inode_update_time(inode, sync_mode);

	if (inode->i_op->update_time)

		ret = inode->i_op->update_time(inode, sync_mode);

	else

		ret = generic_update_time(inode, sync_mode);

	mnt_put_write_access_file(file);

	return ret;

}

include/linux/fs.h

+0 −1
Original line number Diff line number Diff line
@@ -2246,7 +2246,6 @@ enum file_time_flags { 


extern bool atime_needs_update(const struct path *, struct inode *);

extern void touch_atime(const struct path *);

int inode_update_time(struct inode *inode, int flags);



static inline void file_accessed(struct file *file)

{