Commit 214f5252 authored by Zev Weiss's avatar Zev Weiss Committed by Guenter Roeck
Browse files

hwmon: (nct6775) mask out bank number in nct6775_wmi_read_value() 



The first call to nct6775_asuswmi_read() in nct6775_wmi_read_value()
had been passing the full bank+register number instead of just the
lower 8 bits.  It didn't end up actually causing problems because the
second argument of that function is a u8 anyway, but it seems
preferable to be explicit about it at the call site (and consistent
with the rest of the code).

Signed-off-by: default avatarZev Weiss <zev@bewilderbeest.net>
Fixes: 3fbbfc27 ("hwmon: (nct6775) Support access via Asus WMI")
Reviewed-by: default avatarAndy Shevchenko <andy.shevchenko@gmail.com>
Link: https://lore.kernel.org/r/20211111025339.27520-1-zev@bewilderbeest.net


Signed-off-by: default avatarGuenter Roeck <linux@roeck-us.net>
parent dbd3e6ea

drivers/hwmon/nct6775.c

+1 −1
Original line number Diff line number Diff line
@@ -1527,7 +1527,7 @@ static u16 nct6775_wmi_read_value(struct nct6775_data *data, u16 reg) 


	nct6775_wmi_set_bank(data, reg);



	err = nct6775_asuswmi_read(data->bank, reg, &tmp);

	err = nct6775_asuswmi_read(data->bank, reg & 0xff, &tmp);

	if (err)

		return 0;