Commit 21f4c443 authored by Krzysztof Kozlowski's avatar Krzysztof Kozlowski Committed by Vinod Koul
Browse files

soundwire: stream: constify sdw_port_config when adding devices 



sdw_stream_add_master() and sdw_stream_add_slave() do not modify
contents of passed sdw_port_config, so it can be made const for code
safety and as documentation of expected usage.

Signed-off-by: default avatarKrzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Reviewed-by: default avatarPierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Link: https://lore.kernel.org/r/20231120174720.239610-1-krzysztof.kozlowski@linaro.org


Signed-off-by: default avatarVinod Koul <vkoul@kernel.org>
parent 5bdc61ef

drivers/soundwire/stream.c

+5 −5
Original line number Diff line number Diff line
@@ -897,7 +897,7 @@ static struct sdw_port_runtime *sdw_port_alloc(struct list_head *port_list) 
}



static int sdw_port_config(struct sdw_port_runtime *p_rt,

			   struct sdw_port_config *port_config,

			   const struct sdw_port_config *port_config,

			   int port_index)

{

	p_rt->ch_mask = port_config[port_index].ch_mask;
@@ -970,7 +970,7 @@ static int sdw_slave_port_is_valid_range(struct device *dev, int num) 


static int sdw_slave_port_config(struct sdw_slave *slave,

				 struct sdw_slave_runtime *s_rt,

				 struct sdw_port_config *port_config)

				 const struct sdw_port_config *port_config)

{

	struct sdw_port_runtime *p_rt;

	int ret;
@@ -1026,7 +1026,7 @@ static int sdw_master_port_alloc(struct sdw_master_runtime *m_rt, 
}



static int sdw_master_port_config(struct sdw_master_runtime *m_rt,

				  struct sdw_port_config *port_config)

				  const struct sdw_port_config *port_config)

{

	struct sdw_port_runtime *p_rt;

	int ret;
@@ -1861,7 +1861,7 @@ EXPORT_SYMBOL(sdw_release_stream); 
 */

int sdw_stream_add_master(struct sdw_bus *bus,

			  struct sdw_stream_config *stream_config,

			  struct sdw_port_config *port_config,

			  const struct sdw_port_config *port_config,

			  unsigned int num_ports,

			  struct sdw_stream_runtime *stream)

{
@@ -1981,7 +1981,7 @@ EXPORT_SYMBOL(sdw_stream_remove_master); 
 */

int sdw_stream_add_slave(struct sdw_slave *slave,

			 struct sdw_stream_config *stream_config,

			 struct sdw_port_config *port_config,

			 const struct sdw_port_config *port_config,

			 unsigned int num_ports,

			 struct sdw_stream_runtime *stream)

{

include/linux/soundwire/sdw.h

+3 −3
Original line number Diff line number Diff line
@@ -1040,7 +1040,7 @@ int sdw_compute_params(struct sdw_bus *bus); 


int sdw_stream_add_master(struct sdw_bus *bus,

		struct sdw_stream_config *stream_config,

		struct sdw_port_config *port_config,

		const struct sdw_port_config *port_config,

		unsigned int num_ports,

		struct sdw_stream_runtime *stream);

int sdw_stream_remove_master(struct sdw_bus *bus,
@@ -1062,7 +1062,7 @@ void sdw_extract_slave_id(struct sdw_bus *bus, u64 addr, struct sdw_slave_id *id 


int sdw_stream_add_slave(struct sdw_slave *slave,

			 struct sdw_stream_config *stream_config,

			 struct sdw_port_config *port_config,

			 const struct sdw_port_config *port_config,

			 unsigned int num_ports,

			 struct sdw_stream_runtime *stream);

int sdw_stream_remove_slave(struct sdw_slave *slave,
@@ -1084,7 +1084,7 @@ int sdw_update_no_pm(struct sdw_slave *slave, u32 addr, u8 mask, u8 val); 


static inline int sdw_stream_add_slave(struct sdw_slave *slave,

				       struct sdw_stream_config *stream_config,

				       struct sdw_port_config *port_config,

				       const struct sdw_port_config *port_config,

				       unsigned int num_ports,

				       struct sdw_stream_runtime *stream)

{