Unverified Commit 222047f6 authored by Rafael J. Wysocki's avatar Rafael J. Wysocki Committed by Christian Brauner
Browse files

fs: PM: Fix reverse check in filesystems_freeze_callback() 



The freeze_all_ptr check in filesystems_freeze_callback() introduced by
commit a3f8f866 ("power: always freeze efivarfs") is reverse which
quite confusingly causes all file systems to be frozen when
filesystem_freeze_enabled is false.

On my systems it causes the WARN_ON_ONCE() in __set_task_frozen() to
trigger, most likely due to an attempt to freeze a file system that is
not ready for that.

Add a logical negation to the check in question to reverse it as
appropriate.

Fixes: a3f8f866 ("power: always freeze efivarfs")
Cc: 6.18+ <stable@vger.kernel.org> # 6.18+
Signed-off-by: default avatarRafael J. Wysocki <rafael.j.wysocki@intel.com>
Link: https://patch.msgid.link/12788397.O9o76ZdvQC@rafael.j.wysocki


Signed-off-by: default avatarChristian Brauner <brauner@kernel.org>
parent 3f9f0252

fs/super.c

+1 −1
Original line number Diff line number Diff line
@@ -1189,7 +1189,7 @@ static void filesystems_freeze_callback(struct super_block *sb, void *freeze_all 
	if (!sb->s_op->freeze_fs && !sb->s_op->freeze_super)

		return;



	if (freeze_all_ptr && !(sb->s_type->fs_flags & FS_POWER_FREEZE))

	if (!freeze_all_ptr && !(sb->s_type->fs_flags & FS_POWER_FREEZE))

		return;



	if (!get_active_super(sb))