Commit 2260d39c authored Oct 21, 2023 by Jiri Pirko Committed by Jakub Kicinski Oct 23, 2023

tools: ynl-gen: render rsp_parse() helpers if cmd has only dump op



Due to the check in RenderInfo class constructor, type_consistent
flag is set to False to avoid rendering the same response parsing
helper for do and dump ops. However, in case there is no do, the helper
needs to be rendered for dump op. So split check to achieve that.

Signed-off-by: Jiri Pirko <jiri@nvidia.com>
Reviewed-by: Jacob Keller <jacob.e.keller@intel.com>
Link: https://lore.kernel.org/r/20231021112711.660606-4-jiri@resnulli.us


Signed-off-by: Jakub Kicinski <kuba@kernel.org>

parent 4e2846fd

tools/net/ynl/ynl-gen-c.py

+7 −4

Original line number	Diff line number	Diff line
		@@ -1112,11 +1112,14 @@ class RenderInfo:

		# 'do' and 'dump' response parsing is identical
		self.type_consistent = True
		if op_mode != 'do' and 'dump' in op and 'do' in op:
		if op_mode != 'do' and 'dump' in op:
		if 'do' in op:
		if ('reply' in op['do']) != ('reply' in op["dump"]):
		self.type_consistent = False
		elif 'reply' in op['do'] and op["do"]["reply"] != op["dump"]["reply"]:
		self.type_consistent = False
		else:
		self.type_consistent = False

		self.attr_set = attr_set
		if not self.attr_set: