Commit 22b4fb60 authored by Krzysztof Kozlowski's avatar Krzysztof Kozlowski Committed by Linus Walleij
Browse files

dt-bindings: pinctrl: qcom,sc8280xp-pinctrl: fix matching pin config 



Matching PMIC GPIOs config nodes within a '-state' node by '.*' pattern
does not work as expected because of linux,phandle in the DTB:

    'pins' is a required property
    'function' is a required property
    'rx', 'tx' do not match any of the regexes: 'pinctrl-[0-9]+'
    [[59]] is not of type 'object'

Make the schema stricter and expect such nodes to be followed with a
'-pins' suffix.

Signed-off-by: default avatarKrzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Reviewed-by: default avatarBjorn Andersson <andersson@kernel.org>
Link: https://lore.kernel.org/r/20220912061746.6311-32-krzysztof.kozlowski@linaro.org


Signed-off-by: default avatarLinus Walleij <linus.walleij@linaro.org>
parent 31fb6fc8

Documentation/devicetree/bindings/pinctrl/qcom,sc8280xp-pinctrl.yaml

+4 −3
Original line number Diff line number Diff line
@@ -43,8 +43,9 @@ patternProperties: 
    oneOf:

      - $ref: "#/$defs/qcom-sc8280xp-tlmm-state"

      - patternProperties:

          ".*":

          "-pins$":

            $ref: "#/$defs/qcom-sc8280xp-tlmm-state"

        additionalProperties: false



'$defs':

  qcom-sc8280xp-tlmm-state:
@@ -135,13 +136,13 @@ examples: 
                };



                uart-w-subnodes-state {

                        rx {

                        rx-pins {

                                pins = "gpio4";

                                function = "qup14";

                                bias-pull-up;

                        };



                        tx {

                        tx-pins {

                                pins = "gpio5";

                                function = "qup14";

                                bias-disable;