Unverified Commit 230b19bc authored by Jani Nikula's avatar Jani Nikula Committed by Rodrigo Vivi
Browse files

drm/i915/dp: Iterate DSC BPP from high to low on all platforms 



Commit 1c56e9a3 ("drm/i915/dp: Get optimal link config to have best
compressed bpp") tries to find the best compressed bpp for the
link. However, it iterates from max to min bpp on display 13+, and from
min to max on other platforms. This presumably leads to minimum
compressed bpp always being chosen on display 11-12.

Iterate from high to low on all platforms to actually use the best
possible compressed bpp.

Fixes: 1c56e9a3 ("drm/i915/dp: Get optimal link config to have best compressed bpp")
Cc: Ankit Nautiyal <ankit.k.nautiyal@intel.com>
Cc: Imre Deak <imre.deak@intel.com>
Cc: <stable@vger.kernel.org> # v6.7+
Reviewed-by: default avatarImre Deak <imre.deak@intel.com>
Reviewed-by: default avatarAnkit Nautiyal <ankit.k.nautiyal@intel.com>
Signed-off-by: default avatarJani Nikula <jani.nikula@intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/3bba67923cbcd13a59d26ef5fa4bb042b13c8a9b.1738327620.git.jani.nikula@intel.com


(cherry picked from commit 56b0337d)
Signed-off-by: default avatarRodrigo Vivi <rodrigo.vivi@intel.com>
parent 3cf3ec91

drivers/gpu/drm/i915/display/intel_dp.c

+3 −4
Original line number Diff line number Diff line
@@ -2072,11 +2072,10 @@ icl_dsc_compute_link_config(struct intel_dp *intel_dp, 
	/* Compressed BPP should be less than the Input DSC bpp */

	dsc_max_bpp = min(dsc_max_bpp, pipe_bpp - 1);



	for (i = 0; i < ARRAY_SIZE(valid_dsc_bpp); i++) {

		if (valid_dsc_bpp[i] < dsc_min_bpp)

	for (i = ARRAY_SIZE(valid_dsc_bpp) - 1; i >= 0; i--) {

		if (valid_dsc_bpp[i] < dsc_min_bpp ||

		    valid_dsc_bpp[i] > dsc_max_bpp)

			continue;

		if (valid_dsc_bpp[i] > dsc_max_bpp)

			break;



		ret = dsc_compute_link_config(intel_dp,

					      pipe_config,