Commit 23388a1b authored by Carl Vanderlip's avatar Carl Vanderlip Committed by Manivannan Sadhasivam
Browse files

bus: mhi: host: Switch trace_mhi_gen_tre fields to native endian 



Each of the __field() macros were triggering sparse warnings similar to:
trace.h:87:1: sparse: sparse: cast to restricted __le64
trace.h:87:1: sparse: sparse: restricted __le64 degrades to integer
trace.h:87:1: sparse: sparse: restricted __le64 degrades to integer

Change each little endian type to its similarly sized native integer.
Convert inputs into native endian.

Reported-by: default avatarkernel test robot <lkp@intel.com>
Closes: https://lore.kernel.org/oe-kbuild-all/202402071859.8qMhgJEQ-lkp@intel.com/


Fixes: ceeb64f4 ("bus: mhi: host: Add tracing support")
Signed-off-by: default avatarCarl Vanderlip <quic_carlv@quicinc.com>
Reviewed-by: default avatarJeffrey Hugo <quic_jhugo@quicinc.com>
Reviewed-by: default avatarMayank Rana <quic_mrana@quicinc.com>
Reviewed-by: default avatarManivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
Link: https://lore.kernel.org/r/20241004170321.4047492-1-quic_carlv@quicinc.com


Signed-off-by: default avatarManivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
parent 8daf110a

drivers/bus/mhi/host/trace.h

+13 −12
Original line number Diff line number Diff line
@@ -9,6 +9,7 @@ 
#if !defined(_TRACE_EVENT_MHI_HOST_H) || defined(TRACE_HEADER_MULTI_READ)

#define _TRACE_EVENT_MHI_HOST_H



#include <linux/byteorder/generic.h>

#include <linux/tracepoint.h>

#include <linux/trace_seq.h>

#include "../common.h"
@@ -97,18 +98,18 @@ TRACE_EVENT(mhi_gen_tre, 
		__string(name, mhi_cntrl->mhi_dev->name)

		__field(int, ch_num)

		__field(void *, wp)

		__field(__le64, tre_ptr)

		__field(__le32, dword0)

		__field(__le32, dword1)

		__field(uint64_t, tre_ptr)

		__field(uint32_t, dword0)

		__field(uint32_t, dword1)

	),



	TP_fast_assign(

		__assign_str(name);

		__entry->ch_num = mhi_chan->chan;

		__entry->wp = mhi_tre;

		__entry->tre_ptr = mhi_tre->ptr;

		__entry->dword0 = mhi_tre->dword[0];

		__entry->dword1 = mhi_tre->dword[1];

		__entry->tre_ptr = le64_to_cpu(mhi_tre->ptr);

		__entry->dword0 = le32_to_cpu(mhi_tre->dword[0]);

		__entry->dword1 = le32_to_cpu(mhi_tre->dword[1]);

	),



	TP_printk("%s: Chan: %d TRE: 0x%p TRE buf: 0x%llx DWORD0: 0x%08x DWORD1: 0x%08x\n",
@@ -176,19 +177,19 @@ DECLARE_EVENT_CLASS(mhi_process_event_ring, 


	TP_STRUCT__entry(

		__string(name, mhi_cntrl->mhi_dev->name)

		__field(__le32, dword0)

		__field(__le32, dword1)

		__field(uint32_t, dword0)

		__field(uint32_t, dword1)

		__field(int, state)

		__field(__le64, ptr)

		__field(uint64_t, ptr)

		__field(void *, rp)

	),



	TP_fast_assign(

		__assign_str(name);

		__entry->rp = rp;

		__entry->ptr = rp->ptr;

		__entry->dword0 = rp->dword[0];

		__entry->dword1 = rp->dword[1];

		__entry->ptr = le64_to_cpu(rp->ptr);

		__entry->dword0 = le32_to_cpu(rp->dword[0]);

		__entry->dword1 = le32_to_cpu(rp->dword[1]);

		__entry->state = MHI_TRE_GET_EV_STATE(rp);

	),