Commit 2463ae28 authored by Alexander Usyskin's avatar Alexander Usyskin Committed by Greg Kroah-Hartman
Browse files

mei: txe: fix initialization order 



The mei_register() should move before the mei_start() for hook
on class device to work.
Same change was implemented in mei-me, missed from mei-txe.

Fixes: 7704e6be ("mei: hook mei_device on class device")
Signed-off-by: default avatarAlexander Usyskin <alexander.usyskin@intel.com>
Link: https://patch.msgid.link/20251019073659.2646791-1-alexander.usyskin@intel.com


Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 87b318ba

drivers/misc/mei/pci-txe.c

+7 −7
Original line number Diff line number Diff line
@@ -109,19 +109,19 @@ static int mei_txe_probe(struct pci_dev *pdev, const struct pci_device_id *ent) 
		goto end;

	}



	err = mei_register(dev, &pdev->dev);

	if (err)

		goto release_irq;



	if (mei_start(dev)) {

		dev_err(&pdev->dev, "init hw failure.\n");

		err = -ENODEV;

		goto release_irq;

		goto deregister;

	}



	pm_runtime_set_autosuspend_delay(&pdev->dev, MEI_TXI_RPM_TIMEOUT);

	pm_runtime_use_autosuspend(&pdev->dev);



	err = mei_register(dev, &pdev->dev);

	if (err)

		goto stop;



	pci_set_drvdata(pdev, dev);



	/*
@@ -144,8 +144,8 @@ static int mei_txe_probe(struct pci_dev *pdev, const struct pci_device_id *ent) 


	return 0;



stop:

	mei_stop(dev);

deregister:

	mei_deregister(dev);

release_irq:

	mei_cancel_work(dev);

	mei_disable_interrupts(dev);