Commit 246b889c authored by Bartosz Golaszewski's avatar Bartosz Golaszewski
Browse files

gpio: stmpe: don't print out global GPIO numbers in debugfs callbacks 



In order to further limit the number of references to the GPIO base
number stored in struct gpio_chip, replace the global GPIO numbers in
the output of debugfs callbacks by hardware offsets.

Reviewed-by: default avatarLinus Walleij <linus.walleij@linaro.org>
Link: https://lore.kernel.org/r/20250826-gpio-dbg-show-base-v1-1-7f27cd7f2256@linaro.org


Signed-off-by: default avatarBartosz Golaszewski <bartosz.golaszewski@linaro.org>
parent a6f03347

drivers/gpio/gpio-stmpe.c

+6 −8
Original line number Diff line number Diff line
@@ -262,9 +262,8 @@ static void stmpe_gpio_irq_unmask(struct irq_data *d) 
	stmpe_gpio->regs[REG_IE][regoffset] |= mask;

}



static void stmpe_dbg_show_one(struct seq_file *s,

			       struct gpio_chip *gc,

			       unsigned offset, unsigned gpio)

static void stmpe_dbg_show_one(struct seq_file *s, struct gpio_chip *gc,

			       unsigned int offset)

{

	struct stmpe_gpio *stmpe_gpio = gpiochip_get_data(gc);

	struct stmpe *stmpe = stmpe_gpio->stmpe;
@@ -286,7 +285,7 @@ static void stmpe_dbg_show_one(struct seq_file *s, 


	if (dir) {

		seq_printf(s, " gpio-%-3d (%-20.20s) out %s",

			   gpio, label ?: "(none)", str_hi_lo(val));

			   offset, label ?: "(none)", str_hi_lo(val));

	} else {

		u8 edge_det_reg;

		u8 rise_reg;
@@ -354,7 +353,7 @@ static void stmpe_dbg_show_one(struct seq_file *s, 
		irqen = !!(ret & mask);



		seq_printf(s, " gpio-%-3d (%-20.20s) in  %s %13s %13s %25s %25s",

			   gpio, label ?: "(none)",

			   offset, label ?: "(none)",

			   str_hi_lo(val),

			   edge_det_values[edge_det],

			   irqen ? "IRQ-enabled" : "IRQ-disabled",
@@ -366,10 +365,9 @@ static void stmpe_dbg_show_one(struct seq_file *s, 
static void stmpe_dbg_show(struct seq_file *s, struct gpio_chip *gc)

{

	unsigned i;

	unsigned gpio = gc->base;



	for (i = 0; i < gc->ngpio; i++, gpio++) {

		stmpe_dbg_show_one(s, gc, i, gpio);

	for (i = 0; i < gc->ngpio; i++) {

		stmpe_dbg_show_one(s, gc, i);

		seq_putc(s, '\n');

	}

}