Commit 248d3a73 authored by Junjie Cao's avatar Junjie Cao Committed by Dmitry Torokhov
Browse files

Input: ti_am335x_tsc - fix off-by-one error in wire_order validation 



The current validation 'wire_order[i] > ARRAY_SIZE(config_pins)' allows
wire_order[i] to equal ARRAY_SIZE(config_pins), which causes out-of-bounds
access when used as index in 'config_pins[wire_order[i]]'.

Since config_pins has 4 elements (indices 0-3), the valid range for
wire_order should be 0-3. Fix the off-by-one error by using >= instead
of > in the validation check.

Signed-off-by: default avatarJunjie Cao <junjie.cao@intel.com>
Link: https://patch.msgid.link/20251114062817.852698-1-junjie.cao@intel.com


Fixes: bb76dc09 ("input: ti_am33x_tsc: Order of TSC wires, made configurable")
Cc: stable@vger.kernel.org
Signed-off-by: default avatarDmitry Torokhov <dmitry.torokhov@gmail.com>
parent 806ec7b7

drivers/input/touchscreen/ti_am335x_tsc.c

+1 −1
Original line number Diff line number Diff line
@@ -85,7 +85,7 @@ static int titsc_config_wires(struct titsc *ts_dev) 
		wire_order[i] = ts_dev->config_inp[i] & 0x0F;

		if (WARN_ON(analog_line[i] > 7))

			return -EINVAL;

		if (WARN_ON(wire_order[i] > ARRAY_SIZE(config_pins)))

		if (WARN_ON(wire_order[i] >= ARRAY_SIZE(config_pins)))

			return -EINVAL;

	}