Commit 24d97468 authored by Deepak R Varma's avatar Deepak R Varma Committed by Rodrigo Vivi
Browse files

drm/i915/display: Convert i9xx_pipe_crc_auto_source to void 



Convert function i9xx_pipe_crc_auto_source() to return void instead
of int since the current implementation always returns 0 to the caller.
Issue identified using returnvar Coccinelle semantic patch.

$ make coccicheck COCCI=scripts/coccinelle/misc/returnvar.cocci \
M=drivers/gpu/drm/i915/

Signed-off-by: default avatarDeepak R Varma <drv@mailo.com>
Reviewed-by: default avatarRodrigo Vivi <rodrigo.vivi@intel.com>
Signed-off-by: default avatarRodrigo Vivi <rodrigo.vivi@intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/Y8K2SS/zNiPAmLsS@ubun2204.myguest.virtualbox.org
parent e2855f8e

drivers/gpu/drm/i915/display/intel_pipe_crc.c

+7 −16
Original line number Diff line number Diff line
@@ -72,14 +72,13 @@ static int i8xx_pipe_crc_ctl_reg(enum intel_pipe_crc_source *source, 
	return 0;

}



static int i9xx_pipe_crc_auto_source(struct drm_i915_private *dev_priv,

static void i9xx_pipe_crc_auto_source(struct drm_i915_private *dev_priv,

				      enum pipe pipe,

				      enum intel_pipe_crc_source *source)

{

	struct intel_encoder *encoder;

	struct intel_crtc *crtc;

	struct intel_digital_port *dig_port;

	int ret = 0;



	*source = INTEL_PIPE_CRC_SOURCE_PIPE;
@@ -121,8 +120,6 @@ static int i9xx_pipe_crc_auto_source(struct drm_i915_private *dev_priv, 
		}

	}

	drm_modeset_unlock_all(&dev_priv->drm);



	return ret;

}



static int vlv_pipe_crc_ctl_reg(struct drm_i915_private *dev_priv,
@@ -132,11 +129,8 @@ static int vlv_pipe_crc_ctl_reg(struct drm_i915_private *dev_priv, 
{

	bool need_stable_symbols = false;



	if (*source == INTEL_PIPE_CRC_SOURCE_AUTO) {

		int ret = i9xx_pipe_crc_auto_source(dev_priv, pipe, source);

		if (ret)

			return ret;

	}

	if (*source == INTEL_PIPE_CRC_SOURCE_AUTO)

		i9xx_pipe_crc_auto_source(dev_priv, pipe, source);



	switch (*source) {

	case INTEL_PIPE_CRC_SOURCE_PIPE:
@@ -200,11 +194,8 @@ static int i9xx_pipe_crc_ctl_reg(struct drm_i915_private *dev_priv, 
				 enum intel_pipe_crc_source *source,

				 u32 *val)

{

	if (*source == INTEL_PIPE_CRC_SOURCE_AUTO) {

		int ret = i9xx_pipe_crc_auto_source(dev_priv, pipe, source);

		if (ret)

			return ret;

	}

	if (*source == INTEL_PIPE_CRC_SOURCE_AUTO)

		i9xx_pipe_crc_auto_source(dev_priv, pipe, source);



	switch (*source) {

	case INTEL_PIPE_CRC_SOURCE_PIPE: