Commit 24f2cd01 authored Sep 19, 2023 by Jiri Slaby (SUSE) Committed by Greg Kroah-Hartman Oct 03, 2023

tty: use 'if' in send_break() instead of 'goto'



Now, the "jumped-over" code is simple enough to be put inside an 'if'.
Do so to make it 'goto'-less.

Signed-off-by: "Jiri Slaby (SUSE)" <jirislaby@kernel.org>
Link: https://lore.kernel.org/r/20230919085156.1578-16-jirislaby@kernel.org


Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

parent fd99392b

drivers/tty/tty_io.c

+4 −5

Original line number	Diff line number	Diff line
		@@ -2482,11 +2482,10 @@ static int send_break(struct tty_struct *tty, unsigned int duration)
		return -EINTR;

		retval = tty->ops->break_ctl(tty, -1);
		if (retval)
		goto out;
		if (!retval) {
		msleep_interruptible(duration);
		retval = tty->ops->break_ctl(tty, 0);
		out:
		}
		tty_write_unlock(tty);

		if (signal_pending(current))