Commit 25041467 authored by Pavan Chebbi's avatar Pavan Chebbi Committed by Jakub Kicinski
Browse files

bnxt_en: Retain user configured filters when closing 



Driver should not free user created filters from its memory
when closing since we are going to reconfigure them when
we open again.  If the "all" parameter is false, do not free
user configured filters in bnxt_free_ntp_fltrs() and
bnxt_free_l2_filters().

Reviewed-by: default avatarAndy Gospodarek <andrew.gospodarek@broadcom.com>
Signed-off-by: default avatarPavan Chebbi <pavan.chebbi@broadcom.com>
Signed-off-by: default avatarMichael Chan <michael.chan@broadcom.com>
Link: https://lore.kernel.org/r/20240205223202.25341-10-michael.chan@broadcom.com


Signed-off-by: default avatarJakub Kicinski <kuba@kernel.org>
parent 8336a974

drivers/net/ethernet/broadcom/bnxt/bnxt.c

+6 −3
Original line number Diff line number Diff line
@@ -4883,7 +4883,8 @@ static void bnxt_free_ntp_fltrs(struct bnxt *bp, bool all) 
		head = &bp->ntp_fltr_hash_tbl[i];

		hlist_for_each_entry_safe(fltr, tmp, head, base.hash) {

			bnxt_del_l2_filter(bp, fltr->l2_fltr);

			if (!all && (fltr->base.flags & BNXT_ACT_FUNC_DST))

			if (!all && ((fltr->base.flags & BNXT_ACT_FUNC_DST) ||

				     !list_empty(&fltr->base.list)))

				continue;

			bnxt_del_fltr(bp, &fltr->base);

		}
@@ -4926,7 +4927,8 @@ static void bnxt_free_l2_filters(struct bnxt *bp, bool all) 


		head = &bp->l2_fltr_hash_tbl[i];

		hlist_for_each_entry_safe(fltr, tmp, head, base.hash) {

			if (!all && (fltr->base.flags & BNXT_ACT_FUNC_DST))

			if (!all && ((fltr->base.flags & BNXT_ACT_FUNC_DST) ||

				     !list_empty(&fltr->base.list)))

				continue;

			bnxt_del_fltr(bp, &fltr->base);

		}
@@ -5851,6 +5853,7 @@ static void bnxt_hwrm_clear_vnic_filter(struct bnxt *bp) 
			struct bnxt_l2_filter *fltr = vnic->l2_filters[j];



			bnxt_hwrm_l2_filter_free(bp, fltr);

			if (list_empty(&fltr->base.list))

				bnxt_del_l2_filter(bp, fltr);

		}

		vnic->uc_filter_count = 0;